Skip to content

Commit aeb3443

Browse files
Revert "Logging"
This reverts commit f5e51cb75d137da4814b43588297549b8d85155e.
1 parent b3006e6 commit aeb3443

1 file changed

Lines changed: 2 additions & 21 deletions

File tree

proc/community/src/integrationTest/java/org/neo4j/gds/k1coloring/K1ColoringMutateProcTest.java

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@
3838
import org.neo4j.gds.core.Username;
3939
import org.neo4j.gds.core.loading.GraphStoreCatalog;
4040
import org.neo4j.gds.extension.Neo4jGraph;
41-
import org.neo4j.gds.logging.GdsTestLog;
4241

43-
import java.time.Duration;
4442
import java.util.Collections;
4543
import java.util.List;
4644
import java.util.Map;
@@ -59,7 +57,6 @@ public class K1ColoringMutateProcTest extends BaseProcTest {
5957
private static final String TEST_USERNAME = Username.EMPTY_USERNAME.username();
6058
private static final String K1COLORING_GRAPH = "myGraph";
6159
private static final String MUTATE_PROPERTY = "color";
62-
private GdsTestLog log = new GdsTestLog();
6360

6461
@Neo4jGraph
6562
public static final String DB_CYPHER =
@@ -73,7 +70,6 @@ public class K1ColoringMutateProcTest extends BaseProcTest {
7370

7471
@BeforeEach
7572
void setup() throws Exception {
76-
var start = System.nanoTime();
7773
registerProcedures(
7874
K1ColoringMutateProc.class,
7975
GraphWriteNodePropertiesProc.class,
@@ -85,16 +81,11 @@ void setup() throws Exception {
8581
.loadEverything(Orientation.NATURAL)
8682
.yields()
8783
);
88-
log.info("setup took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
8984
}
9085

9186
@AfterEach
9287
void tearDown() {
93-
var start = System.nanoTime();
9488
GraphStoreCatalog.removeAllLoadedGraphs();
95-
log.info("tearDown took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
96-
assertThat(log.getMessages(GdsTestLog.INFO)).containsExactlyInAnyOrder("a");
97-
9889
}
9990

10091
private String expectedMutatedGraph() {
@@ -109,7 +100,6 @@ private String expectedMutatedGraph() {
109100
@ParameterizedTest
110101
@ValueSource(strings = {"gds.k1coloring","gds.beta.k1coloring"})
111102
void testMutate(String tieredProcedure) {
112-
var start = System.nanoTime();
113103
@Language("Cypher")
114104
String query = GdsCypher.call(K1COLORING_GRAPH).algo(tieredProcedure)
115105
.mutateMode()
@@ -143,13 +133,12 @@ void testMutate(String tieredProcedure) {
143133
);
144134
assertThat(containsMutateProperty).isTrue();
145135

146-
log.info("testMutate [%s] took %d ms", tieredProcedure, Duration.ofNanos(System.nanoTime() - start).toMillis());
136+
147137
}
148138

149139
@ParameterizedTest
150140
@ValueSource(strings = {"gds.k1coloring","gds.beta.k1coloring"})
151141
void testMutateEstimate(String tieredProcedure) {
152-
var start = System.nanoTime();
153142
@Language("Cypher")
154143
String query = GdsCypher.call(K1COLORING_GRAPH).algo(tieredProcedure)
155144
.mutateEstimation()
@@ -162,12 +151,10 @@ void testMutateEstimate(String tieredProcedure) {
162151
"bytesMax", 544L,
163152
"requiredMemory", "544 Bytes"
164153
)));
165-
log.info("testMutateEstimate [%s] took %d ms", tieredProcedure, Duration.ofNanos(System.nanoTime() - start).toMillis());
166154
}
167155

168156
@Test
169157
void testWriteBackGraphMutationOnFilteredGraph() {
170-
var start = System.nanoTime();
171158
runQuery("MATCH (n) DETACH DELETE n");
172159
GraphStoreCatalog.removeAllLoadedGraphs();
173160

@@ -212,14 +199,13 @@ void testWriteBackGraphMutationOnFilteredGraph() {
212199
);
213200

214201
assertThat(rowCountB).isEqualTo(2L);
215-
log.info("testWriteBackGraphMutationOnFilteredGraph took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
202+
216203
}
217204

218205

219206

220207
@Test
221208
void testGraphMutationOnFilteredGraph() {
222-
var start = System.nanoTime();
223209
runQuery("MATCH (n) DETACH DELETE n");
224210
GraphStoreCatalog.removeAllLoadedGraphs();
225211

@@ -245,12 +231,10 @@ void testGraphMutationOnFilteredGraph() {
245231
var expectedProperties = Set.of(MUTATE_PROPERTY);
246232
assertEquals(expectedProperties, mutatedGraph.nodePropertyKeys(NodeLabel.of("A")));
247233
assertEquals(Set.of(), mutatedGraph.nodePropertyKeys(NodeLabel.of("B")));
248-
log.info("testGraphMutationOnFilteredGraph took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
249234
}
250235

251236
@Test
252237
void testMutateFailsOnExistingToken() {
253-
var start = System.nanoTime();
254238
String query = GdsCypher.call(K1COLORING_GRAPH).algo("gds", "k1coloring")
255239
.mutateMode()
256240
.addParameter("mutateProperty", MUTATE_PROPERTY)
@@ -261,12 +245,10 @@ void testMutateFailsOnExistingToken() {
261245
"Node property `%s` already exists in the in-memory graph.",
262246
MUTATE_PROPERTY
263247
));
264-
log.info("testMutateFailsOnExistingToken took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
265248
}
266249

267250
@Test
268251
void testRunOnEmptyGraph() {
269-
var start = System.nanoTime();
270252
// Create a dummy node with label "X" so that "X" is a valid label to put use for property mappings later
271253

272254
runQuery("CALL db.createLabel('X')");
@@ -294,7 +276,6 @@ void testRunOnEmptyGraph() {
294276
});
295277

296278
AssertionsForClassTypes.assertThat(rowCount).isEqualTo(1L);
297-
log.info("testRunOnEmptyGraph took %d ms", Duration.ofNanos(System.nanoTime() - start).toMillis());
298279
}
299280

300281

0 commit comments

Comments
 (0)