Url::unescape() unifies %aa to %AA

Author: dg

src/Http/Url.php

@@ -463,9 +463,9 @@ public static function unescape($s, $reserved = '%;/?:@&=+$,')
 		// within a path segment, the characters "/", ";", "=", "?" are reserved
 		// within a query component, the characters ";", "/", "?", ":", "@", "&", "=", "+", ",", "$" are reserved.
 		if ($reserved !== '') {
-			$s = preg_replace(
+			$s = preg_replace_callback(
 				'#%(' . substr(chunk_split(bin2hex($reserved), 2, '|'), 0, -1) . ')#i',
-				'%25$1',
+				function($m) { return '%25' . strtoupper($m[1]); },
 				$s
 			);
 		}

tests/Http/Url.unescape.phpt

@@ -17,5 +17,5 @@ Assert::same( 'foo', Url::unescape('%66%6F%6F', '') );
 Assert::same( 'f%6F%6F', Url::unescape('%66%6F%6F', 'o') );
 Assert::same( '%66oo', Url::unescape('%66%6F%6F', 'f') );
 Assert::same( '%66%6F%6F', Url::unescape('%66%6F%6F', 'fo') );
-Assert::same( '%66%6f%6f', Url::unescape('%66%6f%6f', 'fo') );
+Assert::same( '%66%6F%6F', Url::unescape('%66%6f%6f', 'fo') );
 Assert::same( "%00\x01%02", Url::unescape('%00%01%02', "\x00\x02") );