Default to "all" subjects or sessions for custom transfer if input left blank (#669)

* Fix #619: Handle blank subject/session inputs in TUI

* TUI: clarify placeholder

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing tests for placeholders

* Add test.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test manually, remove quotes from all

* Fix tests.

* Linting.

* chore: retrigger CI

* Revert erroneous test deletion.

* Fix linting.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JoeZiminski <joseph.j.ziminski@gmail.com>

Author: 3 people

datashuttle/tui/tabs/transfer.py

@@ -132,13 +132,13 @@ def compose(self) -> ComposeResult:
             ClickableInput(
                 self.mainwindow,
                 id="transfer_subject_input",
-                placeholder="e.g. sub-001",
+                placeholder="e.g. sub-001 (default: all)",
             ),
             Label("Session(s)", id="transfer_session_label"),
             ClickableInput(
                 self.mainwindow,
                 id="transfer_session_input",
-                placeholder="e.g. ses-001",
+                placeholder="e.g. ses-001 (default: all)",
             ),
             # These are almost identical to create tab
             Label("Datatype(s)", id="transfer_datatype_label"),
@@ -409,6 +409,12 @@ def transfer_data(self) -> Worker[InterfaceOutput]:
                     "#transfer_subject_input", "#transfer_session_input"
                 )
             )
+
+            if sub_names == [""]:
+                sub_names = ["all"]
+            if ses_names == [""]:
+                ses_names = ["all"]
+
             success, output = self.interface.transfer_custom_selection(
                 selected_top_level_folder,
                 sub_names,

tests/tests_tui/test_tui_transfer.py

@@ -218,6 +218,41 @@ async def test_transfer_custom(
 
             await pilot.pause()
 
+    @pytest.mark.asyncio()
+    async def test_custom_transfer_default_sub_ses_all(
+        self, mocker, setup_project_paths
+    ):
+        """
+        This PR tests that for subject and session inputs on the custom
+        transfer screen, passing no argument will call the transfer
+        function with arguments "all".
+        """
+        tmp_config_path, tmp_path, project_name = setup_project_paths.values()
+
+        app = TuiApp()
+        async with app.run_test(size=self.tui_size()) as pilot:
+            await self.check_and_click_onto_existing_project(
+                pilot, project_name
+            )
+            await self.switch_tab(pilot, "transfer")
+
+            await self.scroll_to_click_pause(
+                pilot, "#transfer_custom_radiobutton"
+            )
+
+            spy_download_custom = mocker.spy(
+                pilot.app.screen.interface.project, "download_custom"
+            )
+
+            await self.run_transfer(pilot, "download")
+
+            _, kwargs_ = spy_download_custom.call_args_list[0]
+
+            assert kwargs_["sub_names"] == ["all"]
+            assert kwargs_["ses_names"] == ["all"]
+
+            await pilot.pause()
+
     async def switch_top_level_folder_select(
         self, pilot, id, top_level_folder
     ):

tests/tests_tui/test_tui_widgets_and_defaults.py

@@ -1083,7 +1083,6 @@ async def test_all_checkboxes(self, setup_project_paths):
                     pilot, f"#transfer_{datatype}_checkbox"
                 )
                 expected_transfer[datatype]["on"] = True
-
                 self.check_datatype_checkboxes(
                     pilot, "transfer", expected_transfer
                 )
@@ -1291,7 +1290,7 @@ async def test_all_transfer_widgets(self, setup_project_paths):
                 pilot.app.screen.query_one(
                     "#transfer_subject_input"
                 ).placeholder
-                == "e.g. sub-001"
+                == "e.g. sub-001 (default: all)"
             )
 
             assert (
@@ -1304,7 +1303,7 @@ async def test_all_transfer_widgets(self, setup_project_paths):
                 pilot.app.screen.query_one(
                     "#transfer_session_input"
                 ).placeholder
-                == "e.g. ses-001"
+                == "e.g. ses-001 (default: all)"
             )
 
             assert (