Merge branch 'mount_external_drives' of https://github.com/sumana-2705/datashuttle into mount_external_drives

Author: sumana-2705

.pre-commit-config.yaml

@@ -18,15 +18,15 @@ repos:
           - id: requirements-txt-fixer
           - id: trailing-whitespace
     - repo: https://github.com/astral-sh/ruff-pre-commit
-      rev: v0.11.8
+      rev: v0.11.12
       hooks:
         - id: ruff
     - repo: https://github.com/psf/black
       rev: 25.1.0
       hooks:
           - id: black
     - repo: https://github.com/pre-commit/mirrors-mypy
-      rev: v1.15.0
+      rev: v1.16.0
       hooks:
           - id: mypy
             additional_dependencies:

datashuttle/tui/screens/modal_dialogs.py

@@ -12,7 +12,6 @@
     from datashuttle.tui.app import TuiApp
     from datashuttle.utils.custom_types import InterfaceOutput
 
-import os
 import platform
 from pathlib import Path
 
@@ -171,7 +170,6 @@ def __init__(
         super(SelectDirectoryTreeScreen, self).__init__()
         self.mainwindow = mainwindow
 
-
         if path_ is None:
             path_ = Path().home()
         self.path_ = path_

datashuttle/tui/shared/validate_content.py

@@ -142,7 +142,7 @@ def on_button_pressed(self, event: Button.Pressed) -> None:
             if self.interface:
 
                 if self.interface.project.is_local_project():
-                    include_central = True
+                    include_central = False
                 else:
                     include_central = self.query_one(
                         "#validate_include_central_checkbox"
@@ -155,7 +155,7 @@ def on_button_pressed(self, event: Button.Pressed) -> None:
                 )
                 if not success:
                     self.parent_class.mainwindow.show_modal_error_dialog(
-                        cast(str, output)  # noqa
+                        cast("str", output)
                     )
                 else:
                     self.write_results_to_richlog(output)

datashuttle/utils/rclone.py

@@ -1,4 +1,7 @@
+import os
+import platform
 import subprocess
+import tempfile
 from pathlib import Path
 from subprocess import CompletedProcess
 from typing import Dict, List, Literal
@@ -30,6 +33,45 @@ def call_rclone(command: str, pipe_std: bool = False) -> CompletedProcess:
     return output
 
 
+def call_rclone_through_script(command: str) -> CompletedProcess:
+    """
+    Call rclone through a script, to avoid limits on command-line calls
+    (in particular on Windows). Used for transfers due to generation of
+    large call strings.
+    """
+    system = platform.system()
+
+    command = "rclone " + command
+
+    if system == "Windows":
+        suffix = ".bat"
+    else:
+        suffix = ".sh"
+        command = "#!/bin/bash\n" + command
+
+    with tempfile.NamedTemporaryFile(
+        mode="w", suffix=suffix, delete=False
+    ) as tmp_script:
+        tmp_script.write(command)
+        tmp_script_path = tmp_script.name
+
+    try:
+        if system != "Windows":
+            os.chmod(tmp_script_path, 0o700)
+
+        output = subprocess.run(
+            [tmp_script_path],
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+            shell=False,
+        )
+
+    finally:
+        os.remove(tmp_script_path)
+
+    return output
+
+
 # -----------------------------------------------------------------------------
 # Setup
 # -----------------------------------------------------------------------------
@@ -189,19 +231,17 @@ def transfer_data(
     extra_arguments = handle_rclone_arguments(rclone_options, include_list)
 
     if upload_or_download == "upload":
-        output = call_rclone(
+        output = call_rclone_through_script(
             f"{rclone_args('copy')} "
             f'"{local_filepath}" "{cfg.get_rclone_config_name()}:'
             f'{central_filepath}" {extra_arguments}',
-            pipe_std=True,
         )
 
     elif upload_or_download == "download":
-        output = call_rclone(
+        output = call_rclone_through_script(
             f"{rclone_args('copy')} "
             f'"{cfg.get_rclone_config_name()}:'
             f'{central_filepath}" "{local_filepath}"  {extra_arguments}',
-            pipe_std=True,
         )
 
     return output

docs/source/_static/css/custom.css

@@ -46,7 +46,3 @@ html[data-theme=light] {
   height: auto;
   margin: 5px auto;
 }
-
-.center {
-    text-align: center;
-}