feat(ac): change PCG agentType name (#2582)

Author: paologallinaharbur

CHANGELOG.md

@@ -14,6 +14,9 @@ Remember that the keywords that you can use are the following:
 
 ## Unreleased
 
+### bugfix
+- the agentType for the PCG config should be called pipeline_control_gateway_config_mode
+
 ## v1.16.0 - 2026-06-02
 
 ### 🚀 Enhancements

agent-control/agent-type-registry/newrelic/pipeline-control-gateway-config-0.1.0.yaml

@@ -1,3 +1,6 @@
+# This is the same agent type as `com.newrelic.pipeline_control_gateway_config_mode`, kept in the repository
+# for compatibility with existing deployments and Fleet Control support.
+# It should not drift from the `com.newrelic.pipeline_control_gateway_config_mode` definition!
 namespace: newrelic
 name: com.newrelic.pipeline_control_gateway_config
 version: 0.1.0

agent-control/agent-type-registry/newrelic/pipeline-control-gateway-config-mode-0.1.0.yaml

@@ -0,0 +1,59 @@
+namespace: newrelic
+name: com.newrelic.pipeline_control_gateway_config_mode
+version: 0.1.0
+variables:
+  k8s:
+    config:
+      description: "OTel Collector configuration for the Pipeline Control Gateway"
+      type: yaml
+      required: true
+    config_map_name:
+      description: "Name of the ConfigMap that AC creates and PCG mounts as its configuration source"
+      type: string
+      required: false
+      default: "pipeline-control-gateway-custom-config"
+    deployment_name:
+      description: "Name of the pipeline control deployment for health-checks"
+      type: string
+      required: false
+      default: "pipeline-control-gateway"
+    daemonset_name:
+      description: "Name of the pipeline control daemonset for health-checks (used when PCG is deployed as a DaemonSet via daemonset.enabled=true)"
+      type: string
+      required: false
+      default: "pipeline-control-gateway-daemonset"
+
+deployment:
+  k8s:
+    health:
+      interval: 30s
+      initial_delay: 15s
+      # Both checks coexist: PCG's chart renders either a Deployment or a DaemonSet (mutually
+      # exclusive via daemonset.enabled). The unused workload simply isn't found by name and the
+      # corresponding check is treated as healthy, so the agent reports healthy in both modes.
+      checks:
+        - namespace: ${nr-ac:namespace_agents}
+          name: ${nr-var:deployment_name}
+          kind: Deployment
+          target_namespace: ${nr-ac:namespace_agents}
+        - namespace: ${nr-ac:namespace_agents}
+          name: ${nr-var:daemonset_name}
+          kind: DaemonSet
+          target_namespace: ${nr-ac:namespace_agents}
+    objects:
+      config:
+        apiVersion: v1
+        kind: ConfigMap
+        metadata:
+          name: ${nr-var:config_map_name}
+          namespace: ${nr-ac:namespace_agents}
+        data:
+          deployment-config.yaml: |
+            ${nr-var:config}
+          # This is required as it is also defined in:
+          # https://github.com/newrelic/helm-charts/blob/8c3b88bdf03e600aec8a5d94bab80635b4eec671/charts/pipeline-control-gateway/templates/deployment-configmap.yaml#L7
+          gateway-config.yaml: |
+            reserved_melt_attributes:
+              Metric:
+                - interval.ms
+                - metricName

agent-control/src/agent_type/definition/agent_type_validation_tests.rs

@@ -591,6 +591,43 @@ static AGENT_TYPE_PIPELINE_CONTROL_GATEWAY_CONFIG: LazyLock<AgentTypeValuesTestC
         ..Default::default()
     });
 
+static AGENT_TYPE_PIPELINE_CONTROL_GATEWAY_CONFIG_MODE: LazyLock<AgentTypeValuesTestCase> =
+    LazyLock::new(|| AgentTypeValuesTestCase {
+        agent_type: "newrelic/com.newrelic.pipeline_control_gateway_config_mode:0.1.0",
+        values_k8s: AgentTypeValues {
+            cases: HashMap::from([
+                (
+                    "mandatory fields only",
+                    r#"
+                config:
+                    receivers:
+                        otlp: {}
+                "#,
+                ),
+                (
+                    "check all value types are correct",
+                    r#"
+                config:
+                    receivers:
+                        otlp: {}
+                    exporters:
+                        otlp:
+                            endpoint: "otlp.nr-data.net:4317"
+                    service:
+                        pipelines:
+                            traces:
+                                receivers: [otlp]
+                                exporters: [otlp]
+                config_map_name: "my-otel-config"
+                "#,
+                ),
+            ]),
+            ..Default::default()
+        }
+        .into(),
+        ..Default::default()
+    });
+
 static AGENT_TYPE_EBPF: LazyLock<AgentTypeValuesTestCase> =
     LazyLock::new(|| AgentTypeValuesTestCase {
         agent_type: "newrelic/com.newrelic.ebpf:0.1.0",
@@ -645,6 +682,7 @@ fn get_agent_type_test_cases() -> impl Iterator<Item = &'static AgentTypeValuesT
         &AGENT_TYPE_OTEL_COLLECTOR,
         &AGENT_TYPE_OTEL_COLLECTOR_OLD,
         &AGENT_TYPE_PIPELINE_CONTROL_GATEWAY,
+        &AGENT_TYPE_PIPELINE_CONTROL_GATEWAY_CONFIG_MODE,
         &AGENT_TYPE_PIPELINE_CONTROL_GATEWAY_CONFIG,
         &AGENT_TYPE_EBPF,
     ]

agent-control/src/agent_type/registry/embedded.rs

@@ -137,7 +137,7 @@ pub mod tests {
         }
     }
 
-    const AGENT_TYPE_AMOUNT: usize = 14;
+    const AGENT_TYPE_AMOUNT: usize = 15;
 
     #[test]
     fn check_agent_type_amount_is_unchanged() {

test/k8s-e2e/configmap-agent/ac-values-configmap-agent.yml

@@ -10,7 +10,7 @@ config:
     level: debug
   agents:
     gateway:
-      agent_type: newrelic/com.newrelic.pipeline_control_gateway_config:0.1.0
+      agent_type: newrelic/com.newrelic.pipeline_control_gateway_config_mode:0.1.0
 image:
   repository: agent-control-dev
   tag: e2e-test

test/k8s-e2e/configmap-agent/e2e-configmap-agent.yml

@@ -15,7 +15,7 @@ scenarios:
       - git clone --depth=1 https://github.com/newrelic/helm-charts --branch "${FEATURE_BRANCH:-master}" /tmp/helm-charts-tmp
       # Install agent-control-deployment from the local clone
       - cd ../../../ && helm install agent-control /tmp/helm-charts-tmp/charts/agent-control-deployment --namespace newrelic --create-namespace --set global.licenseKey=${LICENSE_KEY} --set global.cluster=${SCENARIO_TAG} --values test/k8s-e2e/configmap-agent/ac-values-configmap-agent.yml --values test/k8s-e2e/configmap-agent/ac-values-configmap-agent-staging.yml --dependency-update --wait --timeout 5m
-      # Wait for AC to create the ConfigMap via the pipeline_control_gateway_config agent type
+      # Wait for AC to create the ConfigMap via the pipeline_control_gateway_config_mode agent type
       - timeout 120 bash -c 'until kubectl get configmap pcg-otel-config -n newrelic-agents 2>/dev/null; do sleep 5; done'
       # Install pipeline-control-gateway from the public chart, pointing it at the ConfigMap AC created
       - helm repo add newrelic https://helm-charts.newrelic.com && helm repo update