fix nits

Author: vjripoll

Cargo.toml

@@ -44,6 +44,7 @@ chrono = "0.4.45"
 jsonwebtoken = { version = "10.4.0", features = ["aws_lc_rs"] }
 reqwest = { version = "0.13.4", features = ["blocking", "socks"] }
 rstest = "0.26.1"
+serial_test = "3.5.0"
 windows = "0.62.2"
 windows-sys = "0.61.2"
 aws-lc-rs = "1.17.1"

agent-control/Cargo.toml

@@ -116,7 +116,7 @@ fs = { path = "../fs", features = ["mocks"] }
 tokio = { workspace = true, features = ["rt-multi-thread", "macros"] }
 fake = { version = "5.1.0", features = ["derive", "http"] }
 httpmock = { version = "0.8.3", features = ["proxy"] }
-serial_test = "3.5.0"
+serial_test = { workspace = true }
 futures = "0.3.32"
 rcgen = { version = "0.14.8", features = ["crypto"] }
 rstest = { workspace = true }

self-replacer/Cargo.toml

@@ -15,9 +15,9 @@ tempfile = { workspace = true }
 
 [dev-dependencies]
 assert_matches = { workspace = true }
-assert_cmd = "2.2.2"
-predicates = "3.1.4"
-serial_test = "3.5.0"
+assert_cmd = { workspace = true }
+predicates = { workspace = true }
+serial_test = { workspace = true }
 
 [target.'cfg(target_os = "windows")'.dev-dependencies]
 windows = { workspace = true, features = [

self-replacer/tests/integration_tests.rs

@@ -19,6 +19,12 @@ use self_replacer::BACKUP_SUFFIX;
 // Common tests that run on all platforms
 // ============================================================================
 
+// Must run serially: this test writes an executable and then execs it. If another test runs
+// in parallel, its `Command` fork+exec can inherit our still-open write fd to the freshly
+// written binary during the fork->exec window, so our exec fails with ETXTBSY ("text file
+// busy", os error 26). O_CLOEXEC does not help because the fd is only closed on exec, not fork.
+// Serializing removes the write/exec overlap. (test_rollback_on_invalid_path needs no serial:
+// it never execs a freshly written binary.)
 #[test]
 #[serial]
 fn test_self_replacement_with_real_binary() {
@@ -130,6 +136,8 @@ mod unix_specific {
 
     const TEST_EXEC_MODE: u32 = 0o754; // rwxr-xr--
 
+    // Serial for the same reason as test_self_replacement_with_real_binary: writing then
+    // exec-ing a binary races another test's fork+exec and hits ETXTBSY (os error 26).
     #[test]
     #[serial]
     fn test_permission_preservation_with_real_binary() {