direct match

Author: metal-messiah

src/common/v2/script-tracker.js

@@ -30,25 +30,12 @@ export const scriptCorrelations = new Map()
 let poSubscribers = []
 
 /**
- * Checks if two URLs match using flexible suffix matching
- * @param {string} url1 - First URL
- * @param {string} url2 - Second URL
- * @returns {boolean} True if URLs match
- */
-function urlsMatch (url1, url2) {
-  return url1.endsWith(url2) || url2.endsWith(url1)
-}
-
-/**
- * Retrieves a script correlation by URL, falling back to use flexible matching (suffix matching in both directions) if no exact match is found
+ * Retrieves a script correlation by URL using exact matching
  * @param {string} targetUrl - The URL to find
  * @returns {ScriptCorrelation | undefined} - The correlation object if found
  */
 function findCorrelation (targetUrl) {
-  if (scriptCorrelations.has(targetUrl)) return scriptCorrelations.get(targetUrl)
-  for (const [url, correlation] of scriptCorrelations) {
-    if (urlsMatch(url, targetUrl)) return correlation
-  }
+  return scriptCorrelations.get(targetUrl)
 }
 
 /**
@@ -187,14 +174,14 @@ function wasPreloaded (targetUrl) {
 }
 
 /**
- * Checks if a performance entry matches the target MFE script URL
+ * Checks if a performance entry matches the target MFE script URL using exact matching
  * @param {PerformanceResourceTiming} entry - The resource timing entry
  * @param {string} targetUrl - The MFE script URL to match
  * @returns {boolean} True if the entry matches
  */
 function entryMatchesUrl (entry, targetUrl) {
   const entryUrl = cleanURL(entry.name)
-  return urlsMatch(entryUrl, targetUrl)
+  return entryUrl === targetUrl
 }
 
 /**

tests/unit/common/util/script-tracker-correlations.test.js

@@ -953,9 +953,8 @@ describe('script-tracker correlations', () => {
       expect(correlations.length).toBe(2)
     })
 
-    test('URL matching handles partial URLs correctly', () => {
+    test('URL matching requires exact match', () => {
       const fullUrl = 'https://cdn.example.com/path/to/mfe.js'
-      const partialUrl = '/path/to/mfe.js'
 
       const perfEntry = {
         name: fullUrl,
@@ -973,9 +972,10 @@ describe('script-tracker correlations', () => {
       }
 
       mockNavigationEntry = { name: 'https://example.com/' }
+      // Stack trace also has absolute URL (per spec)
       mockStack = `Error
     at findScriptTimings (${scriptTrackerModule.thisFile}:1:1)
-    at init (${partialUrl}:10:5)`
+    at init (${fullUrl}:10:5)`
 
       // Make performance entry available for findScriptTimings lookup
       globalThis.performance.getEntriesByType = jest.fn((type) => {
@@ -987,7 +987,7 @@ describe('script-tracker correlations', () => {
       currentTime = 100
       const timings = scriptTrackerModule.findScriptTimings()
 
-      // Should match even with partial URL
+      // Should match with exact URL
       expect(timings.asset).toBe(fullUrl)
       expect(timings.fetchStart).toBe(10)
       expect(timings.fetchEnd).toBe(40)

tests/unit/common/util/script-tracker.test.js

@@ -421,8 +421,8 @@ describe('script-tracker', () => {
       expect(result.fetchEnd).toBe(0)
     })
 
-    test('handles URL matching when entry URL ends with stack URL', () => {
-      // Resource entry has full path
+    test('handles URL matching with exact match', () => {
+      // Resource entry has absolute URL
       const mockResourceEntry = {
         name: 'https://cdn.example.com/path/app.js',
         initiatorType: 'script',
@@ -439,23 +439,23 @@ describe('script-tracker', () => {
         return []
       })
 
-      // Stack contains full URL matching the resource entry
+      // Stack contains full URL matching the resource entry exactly
       mockStack = `Error
     at findScriptTimings (${scriptTrackerModule.thisFile}:1:1)
     at register (${scriptTrackerModule.thisFile}:2:2)
     at func (https://cdn.example.com/path/app.js:5:10)`
 
       const result = scriptTrackerModule.findScriptTimings()
 
-      // URL matching succeeds, timing info retrieved
+      // Exact URL matching succeeds, timing info retrieved
       expect(result.fetchStart).toBe(100)
       expect(result.type).toBe('script')
     })
 
-    test('handles URL matching when stack URL ends with entry URL', () => {
-      // Resource entry has short relative name
+    test('handles URL matching with absolute URLs', () => {
+      // Resource entry has absolute URL (per spec)
       const mockResourceEntry = {
-        name: 'app.js',
+        name: 'https://cdn.example.com/path/app.js',
         initiatorType: 'script',
         startTime: 100,
         responseEnd: 200
@@ -470,13 +470,13 @@ describe('script-tracker', () => {
         return []
       })
 
-      // Stack has full URL that ends with entry name
+      // Stack has same absolute URL
       mockStack = `Error
     at func (https://cdn.example.com/path/app.js:5:10)`
 
       const result = scriptTrackerModule.findScriptTimings()
 
-      // Reverse matching: stack URL ends with entry URL
+      // Exact URL matching
       expect(result.fetchStart).toBe(100)
       expect(result.type).toBe('script')
     })