Revert to default to 0 for falsy feature values

Author: ptang-nr

src/features/utils/aggregate-base.js

@@ -114,7 +114,7 @@ export class AggregateBase extends FeatureBase {
       }
       function buildOutput (ref) {
         return flagNames.map(flag => {
-          if (ref[flag] === undefined) return null
+          if (!ref[flag]) return 0
           return ref[flag]
         })
       }

tests/unit/features/utils/aggregate-base.test.js

@@ -77,8 +77,7 @@ test('should not perform late configuration checks in AggregateBase', () => {
 })
 
 test('should resolve waitForFlags correctly based on flags with real vals', async () => {
-  // the 4th flag is missing to emulate missing rum response
-  const flagNames = [faker.string.uuid(), faker.string.uuid(), faker.string.uuid(), faker.string.uuid()]
+  const flagNames = [faker.string.uuid(), faker.string.uuid(), faker.string.uuid()]
   const aggregateBase = new AggregateBase(mainAgent, featureName)
   const flagWait = aggregateBase.waitForFlags(flagNames)
   aggregateBase.ee.emit('rumresp', [{
@@ -89,8 +88,7 @@ test('should resolve waitForFlags correctly based on flags with real vals', asyn
     'not-expected1': 1,
     'not-expected2': 2
   }])
-  // use null to avoid locking into 0/OFF mode
-  await expect(flagWait).resolves.toEqual([0, 1, 2, null])
+  await expect(flagWait).resolves.toEqual([0, 1, 2])
 })
 
 test('should return empty array when flagNames is empty', async () => {