fix: Revert circular replacer (#1732)

Author: metal-messiah

src/common/util/stringify.js

@@ -7,35 +7,18 @@ import { ee } from '../event-emitter/contextual-ee'
 
 /**
  * Returns a function for use as a replacer parameter in JSON.stringify() to handle circular references.
- * Uses an array to track the current ancestor chain, allowing the same object to appear
- * multiple times in the structure as long as it's not a circular reference.
  * @see {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value MDN - Cyclical object value}
- * @returns {Function} A function that filters out circular references while allowing duplicate references.
+ * @returns {Function} A function that filters out values it has seen before.
  */
 const getCircularReplacer = () => {
-  const stack = []
-
-  return function (key, value) {
-    if (stack.length > 0) {
-      // Find where we are in the stack
-      const thisPos = stack.indexOf(this)
-      if (~thisPos) {
-        // We're still in the stack, trim it
-        stack.splice(thisPos + 1)
-      } else {
-        // We're not in the stack, add ourselves
-        stack.push(this)
-      }
-
-      // Check if value is in the current ancestor chain
-      if (~stack.indexOf(value)) {
+  const seen = new WeakSet()
+  return (key, value) => {
+    if (typeof value === 'object' && value !== null) {
+      if (seen.has(value)) {
         return
       }
-    } else {
-      // First call, initialize with root
-      stack.push(value)
+      seen.add(value)
     }
-
     return value
   }
 }

tests/unit/common/util/stringify.test.js

@@ -42,37 +42,6 @@ test('should support serializing circular references by omitting the circular re
   expect(stringify(input)).toEqual('{"a":1,"arr":["foo",null]}')
 })
 
-test('should allow the same object to appear multiple times (duplicate references) without treating it as circular', () => {
-  // Simulates the scenario where the same "params" object is shared across multiple error events
-  const sharedParams = {
-    stackHash: -10208229,
-    exceptionClass: 'Error',
-    message: 'test error'
-  }
-
-  const input = {
-    err: [
-      {
-        params: sharedParams,
-        custom: { 'source.id': 'first' },
-        metrics: { count: 1 }
-      },
-      {
-        params: sharedParams, // Same object reference, but not circular
-        custom: { 'entity.guid': 'second' },
-        metrics: { count: 1 }
-      }
-    ]
-  }
-
-  const result = stringify(input)
-  const parsed = JSON.parse(result)
-
-  // Both err objects should have their params preserved
-  expect(parsed.err[0].params).toEqual(sharedParams)
-  expect(parsed.err[1].params).toEqual(sharedParams)
-})
-
 test('should emit an "internal-error" event and still return a string if an error occurs during JSON.stringify', () => {
   jest.spyOn(eventEmitterModule.ee, 'emit')
   jest.spyOn(JSON, 'stringify').mockImplementation(() => {