Skip to content

Commit a83cd47

Browse files
committed
fix: Skip published notification when deleting experiment
1 parent f0dfe9d commit a83cd47

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/delete-experiment.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
needs: [delete-experiment-on-s3]
5353
uses: ./.github/workflows/publish-dev.yml
5454
secrets: inherit
55+
with:
56+
skip_publish_notification: true
5557

5658
# Notify about experiments in Slack
5759
send-slack-notifications:

.github/workflows/publish-dev.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ name: Publish Dev
77

88
on:
99
workflow_call:
10+
inputs:
11+
skip_publish_notification:
12+
description: 'Skip sending published agent Slack notification'
13+
type: boolean
14+
default: false
1015
workflow_dispatch:
1116
push:
1217
branches:
@@ -371,7 +376,7 @@ jobs:
371376

372377
# Notify about new staging deploy in Slack
373378
send-slack-notifications:
374-
if: always() && !cancelled() && !contains(needs.*.result, 'failure') && github.event_name != 'workflow_call' # skip for delete-experiment (avoids double notices + no PR)
379+
if: always() && !cancelled() && !contains(needs.*.result, 'failure') && !inputs.skip_publish_notification
375380
needs: [publish-staging-ab]
376381
runs-on: ubuntu-latest
377382
timeout-minutes: 5

0 commit comments

Comments
 (0)