enabling opentelemetry metrics default as true

enabling opentelemetry metrics default as true

Author: ashishsinghnr

src/Agent/NewRelic/Agent/Core/Config/Configuration.cs

@@ -6877,11 +6877,11 @@ public partial class configurationOpenTelemetryMetrics
         /// </summary>
         public configurationOpenTelemetryMetrics()
         {
-            this.enabledField = false;
+            this.enabledField = true;
         }
 
         [System.Xml.Serialization.XmlAttributeAttribute()]
-        [System.ComponentModel.DefaultValueAttribute(false)]
+        [System.ComponentModel.DefaultValueAttribute(true)]
         public bool enabled
         {
             get

src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd

@@ -2302,10 +2302,11 @@
                                 </xs:annotation>
 
                                 <xs:complexType>
-                                    <xs:attribute name="enabled" type="xs:boolean" default="false">
+                                    <xs:attribute name="enabled" type="xs:boolean" default="true">
                                         <xs:annotation>
                                             <xs:documentation>
-                                                Set this to "true" to enable OpenTelemetry metrics collection and export to New Relic.
+                                                This setting controls whether OpenTelemetry metrics collection and export to New Relic is enabled.
+                                                Defaults to "true".
                                                 This feature must be used together with the global openTelemetry enabled setting.
                                                 Environment variable: NEW_RELIC_OPENTELEMETRY_METRICS_ENABLED
                                             </xs:documentation>

tests/Agent/UnitTests/Core.UnitTest/Configuration/OpenTelemetryConfigurationTests.cs

@@ -47,10 +47,10 @@ public void SetUp()
     [Test]
     public void OpenTelemetryEnabled_DefaultValue_ShouldBeFalse()
     {
-        // Act & Assert
+        // Act & Assert - global opentelemetry.enabled defaults to false, but metrics.enabled defaults to true
         NrAssert.Multiple(
             () => Assert.That(_configuration.OpenTelemetryEnabled, Is.False),
-            () => Assert.That(_configuration.OpenTelemetryMetricsEnabled, Is.False)
+            () => Assert.That(_configuration.OpenTelemetryMetricsEnabled, Is.False) // Still false because global is false
         );
     }
 
@@ -78,15 +78,15 @@ public void OpenTelemetryMetricsEnabled_RequiresBothGlobalAndMetricsSettings_ToB
     }
 
     [Test]
-    public void OpenTelemetryMetricsEnabled_WithOnlyGlobalSettingTrue_ShouldBeFalse()
+    public void OpenTelemetryMetricsEnabled_WithOnlyGlobalSettingTrue_AndMetricsExplicitlyDisabled_ShouldBeFalse()
     {
         // Arrange
         _localConfig.openTelemetry = new configurationOpenTelemetry
         {
             enabled = true,
             metrics = new configurationOpenTelemetryMetrics
             {
-                enabled = false // metrics specific setting is false
+                enabled = false // metrics specific setting is explicitly disabled
             }
         };
 
@@ -99,6 +99,25 @@ public void OpenTelemetryMetricsEnabled_WithOnlyGlobalSettingTrue_ShouldBeFalse(
         );
     }
 
+    [Test]
+    public void OpenTelemetryMetricsEnabled_WithOnlyGlobalSettingTrue_DefaultMetrics_ShouldBeTrue()
+    {
+        // Arrange - metrics.enabled now defaults to true
+        _localConfig.openTelemetry = new configurationOpenTelemetry
+        {
+            enabled = true
+            // metrics element not specified, should use default (true)
+        };
+
+        var configuration = new TestableDefaultConfiguration(_environment, _localConfig, _serverConfig, _runTimeConfig, _securityPoliciesConfiguration, _bootstrapConfiguration, _processStatic, _httpRuntimeStatic, _configurationManagerStatic, _dnsStatic);
+
+        // Act & Assert
+        NrAssert.Multiple(
+            () => Assert.That(configuration.OpenTelemetryEnabled, Is.True),
+            () => Assert.That(configuration.OpenTelemetryMetricsEnabled, Is.True)
+        );
+    }
+
     [Test]
     public void OpenTelemetryMetricsIncludeFilters_ShouldParseCommaSeparatedValues()
     {