Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2819 +/- ##
============================================
+ Coverage 70.34% 70.64% +0.29%
- Complexity 10455 10619 +164
============================================
Files 873 881 +8
Lines 42264 42913 +649
Branches 6414 6486 +72
============================================
+ Hits 29732 30316 +584
- Misses 9641 9674 +33
- Partials 2891 2923 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a replacement of the existing reactor-3.3.0 instrumentation which does not have problems with unexpired async tokens and does not populate the transaction traces with as many entries.
Instead of wrapping the subscriber to track execution across threads, it wraps the Runnable that is created when it does jump threads. This is accomplished by targeting the two places that handle dispatching to another thread, Schedulers and Sinks.
The Netty Reactor instrumentation is left intact and this replacement instrumentation will skip instrumenting Netty Reactor similar to what the original reactor instrumentation did.