Skip to content

Reactor replacement#2819

Open
dhilpipre wants to merge 7 commits intomainfrom
reactor-replacement
Open

Reactor replacement#2819
dhilpipre wants to merge 7 commits intomainfrom
reactor-replacement

Conversation

@dhilpipre
Copy link
Copy Markdown
Collaborator

@dhilpipre dhilpipre commented Apr 2, 2026

This PR is a replacement of the existing reactor-3.3.0 instrumentation which does not have problems with unexpired async tokens and does not populate the transaction traces with as many entries.

Instead of wrapping the subscriber to track execution across threads, it wraps the Runnable that is created when it does jump threads. This is accomplished by targeting the two places that handle dispatching to another thread, Schedulers and Sinks.

The Netty Reactor instrumentation is left intact and this replacement instrumentation will skip instrumenting Netty Reactor similar to what the original reactor instrumentation did.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.64%. Comparing base (5f1a14f) to head (b726c00).
⚠️ Report is 145 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2819      +/-   ##
============================================
+ Coverage     70.34%   70.64%   +0.29%     
- Complexity    10455    10619     +164     
============================================
  Files           873      881       +8     
  Lines         42264    42913     +649     
  Branches       6414     6486      +72     
============================================
+ Hits          29732    30316     +584     
- Misses         9641     9674      +33     
- Partials       2891     2923      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants