Skip to content

Drop LASP (security_policies_token) support #3538

@amychisholm03

Description

@amychisholm03

Description

Other language agents are dropping support for "LASP" which was configurable by config.security_policies_token and have advised us to do so as well. No known Node customers are using this feature, so we should be safe to remove.

Acceptance Criteria

  • config.security_policies_token is removed
  • any logic pertaining to LASP is removed, including tests

Additional Context

A quick ag reveals all the places where this feature currently exists:

❯ ag security_policies_token
test/smoke/lasp-connect.test.js
20:    security_policies_token: 'ffff-ffff-ffff-ffff',
56:    security_policies_token: 'ffff-ffff-ffff-ffff',

test/smoke/agent/lasp-send-trace.test.js
21:      security_policies_token: 'ffff-ffff-ffff-ffff',

test/unit/config/config-defaults.test.js
57:  await t.test('should have no security_policies_token', () => {
58:    assert.equal(configuration.security_policies_token, '')

test/unit/config/config-security.test.js
16:  idempotentEnv({ NEW_RELIC_SECURITY_POLICIES_TOKEN: 'super secure' }, (tc) => {
17:    assert.ok(tc.security_policies_token)
18:    assert.equal(tc.security_policies_token, 'super secure')
23:test('should throw with both high_security and security_policies_token defined', () => {
27:      security_policies_token: 'fffff'
54:    config.security_policies_token = 'TEST-TEST-TEST-TEST'
88:    config.security_policies_token = 'TEST-TEST-TEST-TEST'
93:    config.security_policies_token = ''

test/unit/collector/api-connect.test.js
638:  const SECURITY_POLICIES_TOKEN = 'TEST-TEST-TEST-TEST'
653:    ctx.nr.agent.config.security_policies_token = SECURITY_POLICIES_TOKEN

test/unit/collector/api-login.test.js
18:const SECURITY_POLICIES_TOKEN = 'TEST-TEST-TEST-TEST'
126:    ctx.nr.agent.config.security_policies_token = SECURITY_POLICIES_TOKEN
141:      assert.equal(body[0].security_policies_token, SECURITY_POLICIES_TOKEN)

test/integration/config/index.test.js
29:    delete process.env.NEW_RELIC_SECURITY_POLICIES_TOKEN
35:  process.env.NEW_RELIC_SECURITY_POLICIES_TOKEN = 'faketoken-noexist'

test/integration/security-policies-cross-agent.test.js
20:  security_policies_token: 'AAAA-TEST-TOKE-NNN',

test/helpers/disabled-with-invalid-config/newrelic.js
25:   * `high_security` and `security_policies_token` are mutually exclusive and will throw when configured together.
28:  security_policies_token: 'ffff',

NEWS.md
4055:  `security_policies_token` configured. `high_security` has been added as part of

lib/config/index.js
186:    if (this.security_policies_token) {
190:        'for your account, please ensure the security_policies_token is ' +
292:  if (!this.security_policies_token || !filter) {
1637:  if (!this.security_policies_token) {

lib/config/default.js
51:    security_policies_token: '',

lib/collector/api.js
291:  if (agent.config.security_policies_token) {
292:    preconnectData.security_policies_token = agent.config.security_policies_token

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Triage Needed

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions