fix: use Python 3 for Ubuntu 16.04 to support systemctl3.py (#44)

* fix: use Python 3 for Ubuntu 16.04 to support systemctl3.py

* fix: add python3-apt and symlink python3 to python for Ansible compatibility

* fix: force ubuntu1604 to build from Dockerfile instead of using pre-built image

* fix: install Python 3.6 from deadsnakes PPA for Ansible compatibility

* fix: use local image name for ubuntu1604 when building from Dockerfile

* fix: use Ubuntu 18.04 base image for ubuntu1604 platform (16.04 EOL)

* fix: add gnupg package for GPG key handling

* docs: update README and testing workflow

Author: nravada

.github/workflows/testing.yml

@@ -20,6 +20,6 @@ jobs:
         with:
           repo_base_url: 'https://download.newrelic.com/infrastructure_agent'
           package_name: 'newrelic-infra'
-          package_version: '1.71.0'
+          package_version: '1.72.0'
           gpg_key: 'https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg'
           platforms: "al2,al2023,centos7,centos8,debian-bullseye,debian-trixie,redhat8,redhat9,redhat10,suse15.2,suse15.3,suse15.4,suse15.5,suse15.6,suse15.7,ubuntu1604,ubuntu1804,ubuntu2004,ubuntu2204,ubuntu2404"

README.md

@@ -57,7 +57,7 @@ jobs:
         with:
           repo_base_url: 'http://nr-downloads-ohai-staging.s3-website-us-east-1.amazonaws.com/infrastructure_agent'
           package_name: 'newrelic-infra'
-          package_version: '1.71.0'
+          package_version: '1.72.0'
           gpg_key: 'https://download.newrelic.com/infrastructure_agent/gpg/newrelic-infra.gpg'
           platforms: "al2,al2022,centos7,centos8,debian-bullseye,redhat8,redhat9,suse15.2,suse15.3,suse15.4,suse15.5,suse15.6,suse15.7,ubuntu1604,ubuntu1804,ubuntu2004,ubuntu2204"
 ```

molecule/default/dockerfiles/ubuntu1604

@@ -1,10 +1,11 @@
-FROM ubuntu:16.04
+FROM ubuntu:18.04
 
 RUN apt-get update \
-    && apt-get install -y init ca-certificates sudo curl apt-transport-https python-minimal\
+    && apt-get install -y init ca-certificates sudo curl apt-transport-https python3 gnupg \
+    && ln -sf /usr/bin/python3 /usr/bin/python \
     && apt-get clean all
 
-# Adding fake systemctl
+# Adding fake systemctl (requires Python 3.6+)
 RUN curl https://raw.githubusercontent.com/gdraheim/docker-systemctl-replacement/master/files/docker/systemctl3.py -o /bin/systemctl
 
 RUN chmod +x /bin/systemctl

prepare_platform.sh

@@ -59,17 +59,16 @@ set_platforms_config() {
             \"name\": \"$PLATFORM\",
             \"privileged\": true}]" $FILE_PATH
 
-        if [[ ! -z "${IS_TESTING}" ]]; then
+        # ubuntu1604 needs to build from Dockerfile to use Python 3.6
+        if [[ $PLATFORM == "ubuntu1604" ]]; then
+            yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"image\":\"$PLATFORM\", \"dockerfile\": \"./dockerfiles/$PLATFORM\"}" $FILE_PATH
+        elif [[ ! -z "${IS_TESTING}" ]]; then
             yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"image\":\"$PLATFORM\", \"dockerfile\": \"./dockerfiles/$PLATFORM\"}" $FILE_PATH
         else
             yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"image\":\"ghcr.io/newrelic/pkg-installation-testing-action-$PLATFORM\"}" $FILE_PATH
 
             # Prevent molecule to install extra tools in the pre-build image
             # https://ansible.readthedocs.io/projects/molecule/guides/custom-image/
-            # ubuntu16 python 2 installation was being corrupted by this behaivor.
-            if [[ $PLATFORM == "ubuntu1604" ]]; then
-                yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"pre_build_image\": true}" $FILE_PATH
-            fi
         fi
 
         # debian based distributions need to set up the init command
@@ -78,7 +77,7 @@ set_platforms_config() {
         fi
 
         # set python interpreter groups
-        if [[ $PLATFORM == "al2" || $PLATFORM == "centos7" || $PLATFORM == "ubuntu1604" ]]; then
+        if [[ $PLATFORM == "al2" || $PLATFORM == "centos7" ]]; then
             yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"groups\": [\"python\"]}" $FILE_PATH
         else
             yq -i ".platforms[] |= select(.name == \"$PLATFORM\") += {\"groups\": [\"python3\"]}" $FILE_PATH