Merge pull request #8764 from nextcloud/backport/8754/stable34

[stable34] Performance: Only check permissions when changing content

Author: max-nextcloud

lib/Service/DocumentService.php

@@ -218,16 +218,11 @@ public function writeDocumentState(int $documentId, string $content): void {
 	 */
 	public function addStep(Document $document, Session $session, array $steps, int $version, ?int $recoveryAttempt, ?string $shareToken): array {
 		$documentId = $session->getDocumentId();
-		$file = $this->getFileForSession($session, $shareToken);
-		$readOnly = $this->isReadOnly($file, $shareToken);
 		$stepsToInsert = [];
 		$stepsIncludeQuery = false;
 		$documentState = null;
 		foreach ($steps as $step) {
 			$message = YjsMessage::fromBase64($step);
-			if ($readOnly && $message->isUpdate()) {
-				continue;
-			}
 			// Only accept sync protocol
 			if ($message->getYjsMessageType() !== YjsMessage::YJS_MESSAGE_SYNC) {
 				continue;
@@ -240,10 +235,10 @@ public function addStep(Document $document, Session $session, array $steps, int
 			}
 		}
 		if (count($stepsToInsert) > 0) {
-			if ($readOnly) {
-				throw new NotPermittedException('Read-only client tries to push steps with changes');
+			$file = $this->getFileForSession($session, $shareToken);
+			if (!$this->isReadOnly($file, $shareToken)) {
+				$this->insertSteps($document, $session, $stepsToInsert);
 			}
-			$this->insertSteps($document, $session, $stepsToInsert);
 		}
 
 		// By default, send all steps the user has not received yet.