chore(tests): use custom editor for Mathematics spec

Also introduce `testEditor` test helper.

Signed-off-by: Max <max@nextcloud.com>

Author: max-nextcloud

src/tests/nodes/Mathematics.spec.js

@@ -4,21 +4,11 @@
  */
 
 import { getExtensionField } from '@tiptap/core'
-import { test as baseTest } from 'vitest'
-import { createRichEditor } from '../../EditorFactory.ts'
-import { createMarkdownSerializer } from '../../extensions/Markdown.js'
 import markdownit from '../../markdownit/index.js'
 import { MathBlock, MathInline } from '../../nodes/Mathematics.js'
-import { markdownThroughEditor } from '../testHelpers/markdown.js'
-
-const test = baseTest.extend({
-	// eslint-disable-next-line no-empty-pattern
-	editor: async ({}, use) => {
-		const editor = createRichEditor()
-		await use(editor)
-		editor.destroy()
-	},
-})
+import testEditor from '../testHelpers/testEditor.ts'
+
+const test = testEditor.override('extensions', [MathBlock, MathInline])
 
 describe('Mathematics nodes', () => {
 	describe('Node structure', () => {
@@ -38,38 +28,38 @@ describe('Mathematics nodes', () => {
 	})
 
 	describe('Markdown roundtrip - Inline math', () => {
-		test('simple inline formula', () => {
+		test('simple inline formula', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('$E=mc^2$')).toBe('$E=mc^2$')
 		})
 
-		test('inline formula with complex LaTeX', () => {
+		test('inline formula with complex LaTeX', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('$\\sum_{i=1}^n i$')).toBe('$\\sum_{i=1}^n i$')
 		})
 
-		test('inline formula with fractions', () => {
+		test('inline formula with fractions', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('$\\frac{a}{b}$')).toBe('$\\frac{a}{b}$')
 		})
 
-		test('multiple inline formulas', () => {
+		test('multiple inline formulas', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('$a$ and $b$')).toBe('$a$ and $b$')
 		})
 
-		test('inline formula in text', () => {
+		test('inline formula in text', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('The formula $E=mc^2$ is famous.')).toBe('The formula $E=mc^2$ is famous.')
 		})
 	})
 
 	describe('Markdown roundtrip - Block math', () => {
-		test('simple block formula', () => {
+		test('simple block formula', ({ markdownThroughEditor }) => {
 			expect(markdownThroughEditor('$$\nE=mc^2\n$$')).toBe('$$\nE=mc^2\n$$')
 		})
 
-		test('block formula with complex LaTeX', () => {
+		test('block formula with complex LaTeX', ({ markdownThroughEditor }) => {
 			const input = '$$\n\\sum_{i=1}^n i = \\frac{n(n+1)}{2}\n$$'
 			expect(markdownThroughEditor(input)).toBe(input)
 		})
 
-		test('block formula without newlines', () => {
+		test('block formula without newlines', ({ markdownThroughEditor }) => {
 			// markdown-it-katex accepts this format too
 			expect(markdownThroughEditor('$$E=mc^2$$')).toBe('$$\nE=mc^2\n$$')
 		})
@@ -152,23 +142,15 @@ describe('Mathematics nodes', () => {
 	})
 
 	describe('Serialization to markdown', () => {
-		test('serializes inline math node', ({ editor }) => {
+		test('serializes inline math node', ({ editor, serializeMarkdown }) => {
 			editor.commands.insertInlineMath({ latex: 'E=mc^2' })
 			editor.commands.insertContent(' some more text.')
-
-			const serializer = createMarkdownSerializer(editor.schema)
-			const markdown = serializer.serialize(editor.state.doc)
-
-			expect(markdown).toBe('$E=mc^2$ some more text.')
+			expect(serializeMarkdown()).toBe('$E=mc^2$ some more text.')
 		})
 
-		test('serializes block math node', ({ editor }) => {
+		test('serializes block math node', ({ editor, serializeMarkdown }) => {
 			editor.commands.insertBlockMath({ latex: 'E=mc^2' })
-
-			const serializer = createMarkdownSerializer(editor.schema)
-			const markdown = serializer.serialize(editor.state.doc)
-
-			expect(markdown).toBe('$$\nE=mc^2\n$$')
+			expect(serializeMarkdown()).toBe('$$\nE=mc^2\n$$')
 		})
 	})
 })

src/tests/testHelpers/createCustomEditor.ts

@@ -8,6 +8,7 @@ import type { Content, Extensions } from '@tiptap/core'
 import { Editor } from '@tiptap/core'
 import { Document } from '@tiptap/extension-document'
 import { Text } from '@tiptap/extension-text'
+import Markdown from '../../extensions/Markdown.js'
 import Paragraph from '../../nodes/Paragraph.js'
 
 /**
@@ -21,6 +22,6 @@ export default function createCustomEditor(
 ): Editor {
 	return new Editor({
 		content,
-		extensions: [Document, Paragraph, Text, ...extensions],
+		extensions: [Markdown, Document, Paragraph, Text, ...extensions],
 	})
 }

src/tests/testHelpers/testEditor.ts

@@ -0,0 +1,33 @@
+import type { Editor, Extensions } from '@tiptap/core'
+
+import { test as baseTest } from 'vitest'
+import { createMarkdownSerializer } from '../../extensions/Markdown.js'
+import markdownit from '../../markdownit/index.js'
+import createCustomEditor from './createCustomEditor.js'
+
+export default baseTest.extend<{
+	editor: Editor
+	extensions: Extensions
+	markdownThroughEditor: (input: string) => string
+	serializeMarkdown: () => string
+}>({
+	editor: async ({ extensions }, use) => {
+		const editor = createCustomEditor('', extensions)
+		await use(editor)
+		editor.destroy()
+	},
+	extensions: [],
+	markdownThroughEditor: async ({ editor, serializeMarkdown }, use) => {
+		use((markdown: string) => {
+			const content = markdownit.render(markdown)
+			editor.commands.setContent(content)
+			return serializeMarkdown()
+		})
+	},
+	serializeMarkdown: async ({ editor }, use) => {
+		use(() => {
+			const serializer = createMarkdownSerializer(editor.schema)
+			return serializer.serialize(editor.state.doc)
+		})
+	},
+})