The result of getSnapshot should be cached to avoid an infinite loop

[Echoidf]

Error Type

Console Error

Error Message

The result of getSnapshot should be cached to avoid an infinite loop

at DeployControl (src/components/deploy-control.tsx:33:31)
at PreviewPane (src/components/preview-pane.tsx:283:15)
at Home (src/app/page.tsx:91:15)

Code Frame

31 | const html = useStore((s) => selectActiveTask(s)?.html ?? "");
32 | const taskId = useStore((s) => s.activeTaskId);

33 | const deployments = useStore(
| ^
34 | (s) => selectActiveTask(s)?.deployments ?? [],
35 | );
36 | const removeDeploymentFor = useStore((s) => s.removeDeploymentFor);

Next.js version: 16.2.6 (Turbopack)

[lefarcen]

This is open for community help.

If you'd like to work on it, comment /claim below. The first /claim after the latest release gets it. Any comment, linked PR, or progress note keeps the claim active.

[lefarcen]

Hi @Echoidf — thanks for the clear report and stack trace. I can reproduce the shape of the problem from the code path you pointed at: DeployControl reads selectActiveTask(s)?.deployments ?? [], and that fallback creates a fresh array when the active task has no deployments yet, which matches React/Zustand's getSnapshot caching warning.

Likely fix is small: reuse a stable empty deployments array for that selector (similar to the existing EMPTY_LOG / EMPTY_STATS pattern in PreviewPane), or make sure every task always has deployments initialized before the selector runs. I labeled this as a bug and marked it help wanted / good first issue since it looks scoped to the deployment history selector path.

[lefarcen]

Hi @Echoidf — PR #33 is now open for this exact DeployControl selector loop. It changes the empty-deployments fallback from a freshly allocated [] to a shared EMPTY_DEPLOYMENTS array, which should stabilize the Zustand snapshot for tasks that have no deployment history yet.

We'll track implementation review in #33 and keep this issue open until the fix lands.

[lefarcen]

Quick update: PR #41 is now also open for this same DeployControl render loop. It applies the same core fix shape discussed here: replacing the fresh deployments ?? [] fallback with a stable shared empty deployments array so the Zustand selector stops returning a new snapshot each render.

There is already overlapping PR coverage in #33, so we'll track maintainer review across those PRs and keep this issue open until one fix lands.

[lefarcen]

Quick update: PR #42 is now another open fix for this DeployControl selector loop. It keeps the empty deployments fallback stable instead of returning a new [] for tasks without deployment history, which is the snapshot churn behind the warning reported here.

There are overlapping PRs already under review (#33 and #41), so we'll track maintainer review across those and keep this issue open until one fix lands.

[lefarcen]

Hi @Echoidf — the fix for this has landed in PR #33. It updates DeployControl to reuse a shared empty deployments fallback, so tasks without deployment history should no longer return a fresh [] snapshot on every render.

We'll keep this issue open for validation. When you have a chance, could you pull the latest version and confirm whether the getSnapshot should be cached warning is gone on your side?

[lefarcen]

Closing this as fixed by #33. The merged change keeps the empty deployments fallback stable in DeployControl, and there have been no follow-up reports after the verification window.

If the getSnapshot should be cached warning still appears on the latest version, please comment here and we can reopen.