Skip to content

Commit 30c427c

Browse files
authored
fix(release): allow a skipped windows smoke on the stable lane (#6480)
release-stable.yml offers win_x64_smoke_mode: skip, but choosing it makes the release impossible to finish. The windows smoke uploads its e2e report with if-no-files-found: warn, so a skipped smoke leaves the report directory empty and publishes no artifact; finalize then downloads that artifact unconditionally and fails — after every platform has already built, signed and notarized, and after the pre-flight tag check has passed. Twenty-five minutes of work is thrown away for a report nothing downstream reads. Guard the download on the same condition that gates the smoke itself, matching how the linux report is guarded by its build result. The mac report stays unconditional because the mac smoke has no skip switch.
1 parent 65e1b2a commit 30c427c

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/release-stable.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1261,7 +1261,15 @@ jobs:
12611261
name: open-design-release-mac-e2e-report
12621262
path: ${{ runner.temp }}/release-report/mac
12631263

1264+
# The windows smoke uploads this artifact with `if-no-files-found: warn`,
1265+
# so a skipped smoke leaves an empty report directory and publishes no
1266+
# artifact at all. Downloading it unconditionally then fails finalize —
1267+
# after all three platforms have already built, signed and notarized —
1268+
# which makes `win_x64_smoke_mode: skip` unusable on the stable lane even
1269+
# though the input offers it. Guard it the way the linux report is guarded
1270+
# by its own build result.
12641271
- name: Download windows e2e spec report
1272+
if: ${{ inputs.win_x64_smoke_mode != 'skip' }}
12651273
uses: actions/download-artifact@v8
12661274
with:
12671275
name: open-design-release-win-e2e-report

0 commit comments

Comments
 (0)