Commit 30c427c
authored
fix(release): allow a skipped windows smoke on the stable lane (#6480)
release-stable.yml offers win_x64_smoke_mode: skip, but choosing it makes the
release impossible to finish. The windows smoke uploads its e2e report with
if-no-files-found: warn, so a skipped smoke leaves the report directory empty
and publishes no artifact; finalize then downloads that artifact
unconditionally and fails — after every platform has already built, signed and
notarized, and after the pre-flight tag check has passed. Twenty-five minutes
of work is thrown away for a report nothing downstream reads.
Guard the download on the same condition that gates the smoke itself, matching
how the linux report is guarded by its build result. The mac report stays
unconditional because the mac smoke has no skip switch.1 parent 65e1b2a commit 30c427c
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1261 | 1261 | | |
1262 | 1262 | | |
1263 | 1263 | | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
1264 | 1271 | | |
| 1272 | + | |
1265 | 1273 | | |
1266 | 1274 | | |
1267 | 1275 | | |
| |||
0 commit comments