Skip to content

Update the untar module - #904

Merged
d4straub merged 5 commits into
nf-core:devfrom
ebete:update-untar
Jul 21, 2025
Merged

Update the untar module#904
d4straub merged 5 commits into
nf-core:devfrom
ebete:update-untar

Conversation

@ebete

@ebete ebete commented Jul 17, 2025

Copy link
Copy Markdown
Member

Update the untar module to the latest version as the current one still tries to pull from Anaconda's ToS-covered channels, which is problematic for many users.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.
  • Merging template updates 3.3.2 #905 is merged into this PR.

@nf-core-bot

Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@d4straub

d4straub commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator

Hi there, thanks for the PR! The failing CI tests seem to be due to a change in output compared to the expected. Those tests are relatively new and unfortunately there seems to be still a bug because its not telling what file/entry/change is the actual cause. An update to the most recent nf-core template might help, but that isnt in the scope of this PR, ofc.
What changes are taking place could be checked by running in the directory containing the pipeline code:

nf-test test tests/doubleprimers.nf.test --profile=+singularity --update-snapshot --clean-snapshot --verbose
nf-test test tests/reftaxcustom.nf.test --profile=+singularity --update-snapshot --clean-snapshot --verbose

I might be able to do that soon-ish.
Edit: I rather attempt the template update: #905

@ebete

ebete commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

@d4straub Thanks. The test suite run locally finishes without failure at least. Once 3.3.2 merges I'll try to merge it in here and try again to see if it makes any difference.

@ebete
ebete marked this pull request as ready for review July 20, 2025 10:46

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the template update indeed did its job, the reason for the failing tests is now detailed as expected.
In files tests/doubleprimers.nf.test.snap & tests/reftaxcustom.nf.test.snap the entry "untar": 1.3 has to be replaced by "untar": 1.34. When you will have done that, the tests should pass.
Other than that then changes seem fine.

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!
Is it fine to you when I merge it? Usually I find merging is up to the opener of the PR, but you seem to be no nf-core member and might be not able to hit that merge button?

@ebete

ebete commented Jul 21, 2025

Copy link
Copy Markdown
Member Author

@d4straub yes please go ahead :). I'm indeed not able to merge as I don't have write access.

Thanks for reviewing

@d4straub
d4straub merged commit 3c81f87 into nf-core:dev Jul 21, 2025
33 checks passed
@ebete
ebete deleted the update-untar branch July 21, 2025 12:11
@ebete

ebete commented Jul 21, 2025

Copy link
Copy Markdown
Member Author

Thank you.
A small thing I just now noticed: I put the PR under the wrong section in the CHANGELOG. It should most likely be moved under the Dependencies section instead of Fixed. Sorry about that

@d4straub

Copy link
Copy Markdown
Collaborator

Hi, no problem, before a release I typically look through the CHANGELOG anyway and modify if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants