Update the untar module - #904
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.3.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
Hi there, thanks for the PR! The failing CI tests seem to be due to a change in output compared to the expected. Those tests are relatively new and unfortunately there seems to be still a bug because its not telling what file/entry/change is the actual cause. An update to the most recent nf-core template might help, but that isnt in the scope of this PR, ofc. I might be able to do that soon-ish. |
|
@d4straub Thanks. The test suite run locally finishes without failure at least. Once |
d4straub
left a comment
There was a problem hiding this comment.
So the template update indeed did its job, the reason for the failing tests is now detailed as expected.
In files tests/doubleprimers.nf.test.snap & tests/reftaxcustom.nf.test.snap the entry "untar": 1.3 has to be replaced by "untar": 1.34. When you will have done that, the tests should pass.
Other than that then changes seem fine.
d4straub
left a comment
There was a problem hiding this comment.
Great, thanks!
Is it fine to you when I merge it? Usually I find merging is up to the opener of the PR, but you seem to be no nf-core member and might be not able to hit that merge button?
|
@d4straub yes please go ahead :). I'm indeed not able to merge as I don't have write access. Thanks for reviewing |
|
Thank you. |
|
Hi, no problem, before a release I typically look through the CHANGELOG anyway and modify if needed. |
Update the
untarmodule to the latest version as the current one still tries to pull from Anaconda's ToS-covered channels, which is problematic for many users.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.