Commit e26c67a
authored
Add
# Pull Request
## π€¨ Rationale
Moves `UnitFormat` to a standalone npm library and modifies it to be
usable from both browser and node applications.
## π©βπ» Implementation
- Added `@ni/unit-format` using node esm compliant import paths
- Breaking: Renamed types to align with folder layout and with nimble
components naming conventions, [see
discussion](#2787 (comment)).
- Did regex searches for `\w+unitformat` and `\w+unitscale` which are
the primary uses of the public api for missed renames
## π§ͺ Testing
- Added jasmine node and karma browser tests
- Draft [SystemLinkShared
PR](https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/1139993),
looks like usage was well-encapsulated so trivial change
## β
Checklist
- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed. Added README and Contributing for
library.@ni/unit-format library (#2787)1 parent 224ec91 commit e26c67a
64 files changed
Lines changed: 908 additions & 477 deletions
File tree
- change
- packages
- angular-workspace
- example-client-app/src/tests
- nimble-angular
- pipes
- tests
- nimble-components
- src
- table-column/number-text
- models
- tests
- unit
- base
- byte
- tests
- celsius
- tests
- fahrenheit
- tests
- volt
- tests
- utilities/unit-format/unit-scale
- storybook/src
- nimble/table-column/number-text
- unit-format
- spec/support
- src
- decimal
- default
- scaled-unit-format
- intl-number-format
- manually-translated
- tests
- scaled-unit
- tests
- unit-scale
- byte-1024
- byte
- celsius
- fahrenheit
- passthrough
- tests
- utilities
- volt
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
75 | | - | |
76 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments