Skip to content

Commit fd90479

Browse files
author
Vivin Krishna R N
committed
Remove event and address comments
1 parent 4ae72ce commit fd90479

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

packages/angular-workspace/example-client-app/src/app/customapp/customapp.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<div class="container-label">Chip</div>
7878
<nimble-chip>Outline Chip</nimble-chip>
7979
<nimble-chip appearance="block">Block Chip</nimble-chip>
80-
<nimble-chip removable (removeEvent)="onChipRemove()">Removable Chip</nimble-chip>
80+
<nimble-chip removable (remove)="onChipRemove()">Removable Chip</nimble-chip>
8181
<nimble-chip disabled>Disabled Chip</nimble-chip>
8282
</div>
8383
<div class="sub-container">

packages/angular-workspace/nimble-angular/chip/nimble-chip.directive.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Directive, ElementRef, EventEmitter, HostListener, Input, Output, Renderer2 } from '@angular/core';
1+
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
22
import { type Chip, chipTag } from '@ni/nimble-components/dist/esm/chip';
33
import { ChipAppearance } from '@ni/nimble-components/dist/esm/chip/types';
44
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
@@ -39,14 +39,5 @@ export class NimbleChipDirective {
3939
this.renderer.setProperty(this.elementRef.nativeElement, 'appearance', value);
4040
}
4141

42-
@Output() public removeEvent = new EventEmitter<void>();
43-
4442
public constructor(private readonly renderer: Renderer2, private readonly elementRef: ElementRef<Chip>) {}
45-
46-
@HostListener('remove', ['$event'])
47-
public onRemove($event: Event): void {
48-
if ($event.target === this.elementRef.nativeElement) {
49-
this.removeEvent.emit();
50-
}
51-
}
5243
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export { ChipPageObject } from '@ni/nimble-components/dist/esm/chip/testing/chip.pageobject';
1+
export { ChipPageObject } from './chip.pageobject';

0 commit comments

Comments
 (0)