Don't snooze high alarm when there is no IOB (#6348)

The Bolus Wizard Preview plugin snoozes a high alarm when its
`bolusEstimate` is below the snooze threshold, treating that as "enough
insulin on board to cover the high". But `bolusEstimate` is 0 in a case
that has nothing to do with IOB coverage: when the BG is above the alarm
threshold (`bgTargetTop`) yet still below the profile's high target, so
neither the high nor low branch of calc() runs. With no insulin on board
this leaves bolusEstimate at its initial 0 and a genuine high alarm is
silenced -- the scenario reported in #6348 (complete profile, no insulin
treatments). Because the snooze is requested at URGENT level and
snoozedBy() matches by level across the group, it can also suppress other
urgent alarms for the snooze duration.

Guard the snooze on `prop.iob > 0` so a high is only snoozed when there
is actually insulin on board to cover it. Legitimate "enough IOB"
snoozing is unchanged.

Adds regression tests for the reported scenario (BG below the profile
high target with no IOB) and for the unchanged enough-IOB snooze.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: IsraelAfangideh

lib/plugins/boluswizardpreview.js

@@ -107,7 +107,11 @@ function init (ctx) {
     var ar2EventType = sbx.properties.ar2 && sbx.properties.ar2.eventType;
     var high = ar2EventType === 'high' || prop.scaledSGV >= sbx.scaleMgdl(sbx.settings.thresholds.bgTargetTop);
 
-    return high && prop.bolusEstimate < settings.snoozeBWP;
+    // Require real IOB: a bolusEstimate of 0 does not imply insulin is covering
+    // the high -- it also happens when the BG is above the alarm threshold but
+    // below the profile's high target. Without IOB that must not be read as
+    // "enough IOB" and silence a genuine high alarm. See #6348.
+    return high && prop.iob > 0 && prop.bolusEstimate < settings.snoozeBWP;
   };
 
 

tests/boluswizardpreview.test.js

@@ -15,6 +15,7 @@ describe('boluswizardpreview', function ( ) {
   var ar2 = require('../lib/plugins/ar2')(ctx);
   var iob = require('../lib/plugins/iob')(ctx);
   var bgnow = require('../lib/plugins/bgnow')(ctx);
+  var simplealarms = require('../lib/plugins/simplealarms')(ctx);
 
   function prepareSandbox ( ) {
     var sbx = require('../lib/sandbox')().serverInit(env, ctx);
@@ -297,6 +298,46 @@ describe('boluswizardpreview', function ( ) {
 
   });
 
+  it('does not snooze a high alarm with no IOB when the BG sits below the profile high target', function (done) {
+    // Faithful to #6348: a complete profile whose target_high is above the
+    // current high reading leaves bolusEstimate at 0 even though calc succeeds.
+    // With no insulin on board that must not be read as "enough IOB".
+    ctx.notifications.resetStateForTests();
+    ctx.notifications.initRequests();
+    ctx.ddata.sgvs = [{mills: before, mgdl: 270}, {mills: now, mgdl: 273}];
+    ctx.ddata.treatments = []; // no insulin -> no IOB
+    ctx.ddata.profiles = [{ dia: 3, units: ctx.settings.units, sens: 100, target_high: 280, target_low: 100 }];
+
+    var sbx = prepareSandbox();
+
+    simplealarms.checkNotifications(sbx);
+    boluswizardpreview.checkNotifications(sbx);
+
+    var highest = ctx.notifications.findHighestAlarm('default');
+    should.exist(highest);
+    should(ctx.notifications.snoozedBy(highest)).not.be.ok();
+
+    done();
+  });
+
+  it('still snoozes a high alarm when real IOB covers it', function (done) {
+    // Contract contrast for #6348: the guard discriminates on iob > 0, so a
+    // genuine "enough IOB" high is still snoozed.
+    ctx.notifications.resetStateForTests();
+    ctx.notifications.initRequests();
+    ctx.ddata.sgvs = [{mills: before, mgdl: 295}, {mills: now, mgdl: 300}];
+    ctx.ddata.treatments = [{mills: before, insulin: '5.0'}];
+    ctx.ddata.profiles = [profile];
+
+    var sbx = prepareSandbox();
+    var prop = sbx.properties.bwp;
+
+    prop.iob.should.be.greaterThan(0);
+    boluswizardpreview.highSnoozedByIOB(prop, {snoozeBWP: 0.10}, sbx).should.equal(true);
+
+    done();
+  });
+
   it('set a pill to the BWP with infos', function (done) {
     // BWP-TIME-001: Use fixed timestamp for deterministic IOB calculation
     // Using `now` instead of `Date.now()` prevents timing drift between