Merge pull request #18 from nihaopaul/fix/reqwest-client-leak

Fix potential memory leak by reusing reqwest::Client

Author: nihaopaul

cloudflare-authenticator/src/lib.rs

@@ -40,6 +40,7 @@ pub struct Config {
 pub struct Authenticator {
     config: Config,
     certs: Arc<Mutex<Certs>>,
+    client: reqwest::Client,
 }
 
 #[derive(Debug, Serialize, Deserialize)]
@@ -97,6 +98,7 @@ impl Authenticator {
                 },
                 public_certs: vec![],
             })),
+            client: reqwest::Client::new(),
         };
 
         // Start the background task to update certs periodically
@@ -146,8 +148,8 @@ impl Authenticator {
     }
 
     async fn fetch_certs(&self) -> Result<(), ValidationError> {
-        let client = reqwest::Client::new();
-        let response = client
+        let response = self
+            .client
             .get(&format!("{}/cdn-cgi/access/certs", &self.config.api))
             .header(header::CONTENT_TYPE, "application/json")
             .send()

cloudflare-dynamic-config/src/lib.rs

@@ -20,6 +20,7 @@ pub struct Config {
 pub struct DynamicConfigManager {
     config: Config,
     apps: Arc<Mutex<Vec<App>>>, // Use Arc and Mutex for shared access
+    client: reqwest::Client,
 }
 
 #[derive(Error, Debug)]
@@ -41,6 +42,7 @@ impl DynamicConfigManager {
         let manager = Self {
             config,
             apps: Arc::new(Mutex::new(Vec::new())),
+            client: reqwest::Client::new(),
         };
 
         // Start the background task to update apps periodically
@@ -63,8 +65,8 @@ impl DynamicConfigManager {
     async fn fetch_apps(&self) -> Result<(), ConfigError> {
         let query_params = [("match", "any"), ("ui_apps", "true")];
 
-        let client = reqwest::Client::new();
-        let response = client
+        let response = self
+            .client
             .get(&format!(
                 "{}?{}",
                 self.config.api.clone(),