docs(sacp): fix all rustdoc link warnings

- Fix MatchMessage links in jsonrpc.rs
- Fix DynamicHandlerRegistration reference (was private)
- Fix Self::connection_cx reference (method didn't exist)
- Fix McpServerConnect links in mcp_server module
- Fix SessionBuilder::with_mcp_server and JrConnectionBuilder links
- Fix McpServerBuilder::tool_fn links in lib.rs macros

Author: nikomatsakis

src/sacp/src/jsonrpc.rs

@@ -1071,7 +1071,7 @@ impl<H: JrMessageHandler, R: JrResponder<H::Link>> JrConnectionBuilder<H, R> {
     ///
     /// # Borrow Checker Considerations
     ///
-    /// You may find that [`MatchMessage`] is a better choice than this method
+    /// You may find that [`MatchMessage`](`crate::util::MatchMessage`) is a better choice than this method
     /// for implementing custom handlers. It offers a very similar API to
     /// [`JrConnectionBuilder`] but is structured to apply each test one at a time
     /// (sequentially) instead of setting them all up at once. This sequential approach
@@ -1106,7 +1106,7 @@ impl<H: JrMessageHandler, R: JrResponder<H::Link>> JrConnectionBuilder<H, R> {
     /// ```
     ///
     /// You can work around this by using `apply()` to process messages one at a time,
-    /// or use [`MatchMessage`] which provides a similar API but applies handlers sequentially:
+    /// or use [`MatchMessage`](`crate::util::MatchMessage`) which provides a similar API but applies handlers sequentially:
     ///
     /// ```ignore
     /// use sacp::{MessageCx, Handled};
@@ -1837,7 +1837,7 @@ impl<Link: JrLink> JrConnectionCx<Link> {
     ///
     /// If they decline to handle the message, then the message is passed to the regular registered handlers.
     ///
-    /// The handler will stay registered until the [`DynamicHandlerRegistration`] is dropped.
+    /// The handler will stay registered until the returned registration guard is dropped.
     pub fn add_dynamic_handler(
         &self,
         handler: impl JrMessageHandler<Link = Link> + 'static,
@@ -1893,11 +1893,10 @@ impl<Link: JrLink> Drop for DynamicHandlerRegistration<Link> {
 ///
 /// 1. **Respond to the request** - Use [`respond`](Self::respond) or
 ///    [`respond_with_result`](Self::respond_with_result) to send the response
-/// 2. **Send other messages** - Use [`connection_cx`](Self::connection_cx) to access the
-///    underlying [`JrConnectionCx`], giving access to
-///    [`send_request`](JrConnectionCx::send_request),
-///    [`send_notification`](JrConnectionCx::send_notification), and
-///    [`spawn`](JrConnectionCx::spawn)
+/// 2. **Send other messages** - Use the [`JrConnectionCx`] parameter passed to your
+///    handler, which provides [`send_request`](`JrConnectionCx::send_request`),
+///    [`send_notification`](`JrConnectionCx::send_notification`), and
+///    [`spawn`](`JrConnectionCx::spawn`)
 ///
 /// # Example
 ///

src/sacp/src/lib.rs

@@ -147,7 +147,7 @@ mod session;
 pub use session::*;
 
 /// This is a hack that must be given as the final argument of
-/// [`McpServerBuilder::tool_fn`] when defining tools.
+/// [`McpServerBuilder::tool_fn`](`crate::mcp_server::McpServerBuilder::tool_fn`) when defining tools.
 /// Look away, lest ye be blinded by its vileness!
 ///
 /// Fine, if you MUST know, it's a horrific workaround for not having
@@ -162,7 +162,7 @@ macro_rules! tool_fn_mut {
 }
 
 /// This is a hack that must be given as the final argument of
-/// [`McpServerBuilder::tool_fn`] when defining stateless concurrent tools.
+/// [`McpServerBuilder::tool_fn`](`crate::mcp_server::McpServerBuilder::tool_fn`) when defining stateless concurrent tools.
 /// See [`tool_fn_mut!`] for the gory details.
 #[macro_export]
 macro_rules! tool_fn {

src/sacp/src/mcp_server/builder.rs

@@ -242,8 +242,8 @@ where
 
     /// Create an MCP server from this builder.
     ///
-    /// This builder can be attached to new sessions (see [`SessionBuilder::with_mcp_server`])
-    /// or served up as part of a proxy (see [`JrConnectionBuilder::with_mcp_server`]).
+    /// This builder can be attached to new sessions (see [`SessionBuilder::with_mcp_server`](`crate::SessionBuilder::with_mcp_server`))
+    /// or served up as part of a proxy (see [`JrConnectionBuilder::with_mcp_server`](`crate::JrConnectionBuilder::with_mcp_server`)).
     pub fn build(self) -> McpServer<Link, Responder> {
         McpServer::new(
             McpServerBuilt {

src/sacp/src/mcp_server/mod.rs

@@ -23,7 +23,7 @@
 //!
 //! ## Custom MCP Server Implementations
 //!
-//! You can implement [`McpServerConnect`] to create custom MCP servers:
+//! You can implement [`McpServerConnect`](`crate::mcp_server::McpServerConnect`) to create custom MCP servers:
 //!
 //! ```rust,ignore
 //! use sacp::mcp_server::{McpServer, McpServerConnect, McpContext};

src/sacp/src/mcp_server/server.rs

@@ -17,10 +17,10 @@ use crate::{
 
 /// An MCP server that can be attached to ACP connections.
 ///
-/// `McpServer` wraps an [`McpServerConnect`] implementation and can be used either:
-/// - As a message handler via [`JrConnectionBuilder::with_handler`], automatically
+/// `McpServer` wraps an [`McpServerConnect`](`super::McpServerConnect`) implementation and can be used either:
+/// - As a message handler via [`JrConnectionBuilder::with_handler`](`crate::JrConnectionBuilder::with_handler`), automatically
 ///   attaching to new sessions
-/// - Manually via [`Self::into_dynamic_handler`] for more control
+/// - Manually for more control
 ///
 /// # Creating an MCP Server
 ///
@@ -33,7 +33,7 @@ use crate::{
 ///     .build();
 /// ```
 ///
-/// Or implement [`McpServerConnect`] for custom server behavior:
+/// Or implement [`McpServerConnect`](`super::McpServerConnect`) for custom server behavior:
 ///
 /// ```rust,ignore
 /// let server = McpServer::new(MyCustomServerConnect);
@@ -65,7 +65,7 @@ impl<Link: JrLink, Responder: JrResponder<Link>> McpServer<Link, Responder>
 where
     Link: HasPeer<AgentPeer>,
 {
-    /// Create an MCP server from something that implements the [`McpServerConnect`] trait.
+    /// Create an MCP server from something that implements the [`McpServerConnect`](`super::McpServerConnect`) trait.
     ///
     /// # See also
     ///

src/sacp/src/session.rs

@@ -328,7 +328,7 @@ where
     /// [`start_session`](Self::start_session) which block the current task.
     ///
     /// This should not be used from inside a message handler like
-    /// [`JrConnectionBuilder::on_receive_request`] or [`JrMessageHandler`]
+    /// [`JrConnectionBuilder::on_receive_request`](`crate::JrConnectionBuilder::on_receive_request`) or [`JrMessageHandler`]
     /// implementations.
     pub fn block_task(self) -> SessionBuilder<Link, Responder, Blocking> {
         SessionBuilder {