Make clippy happy

Ignore warnings with false positives. Remove unused structs. Implement
`Default` for structs with `fn new`.

Author: hrxi

Cargo.toml

@@ -164,6 +164,8 @@ keywords = ["nimiq", "cryptocurrency", "blockchain"]
 clippy.large_enum_variant = "allow"
 clippy.too_many_arguments = "allow"
 clippy.type_complexity = "allow"
+clippy.empty_docs = "allow" # false positives: https://github.com/rust-lang/rust-clippy/issues/12377
+clippy.assigning_clones = "allow" # false positives: https://github.com/rust-lang/rust-clippy/issues/12709
 
 [workspace.dependencies]
 nimiq-account = { path = "primitives/account", default-features = false }

network-libp2p/src/connection_pool/behaviour.rs

@@ -171,7 +171,7 @@ impl<T: Ord> ConnectionState<T> {
 
     /// Returns whether a connection ID is banned
     fn is_banned(&self, id: T) -> bool {
-        self.banned.get(&id).is_some()
+        self.banned.contains(&id)
     }
 
     /// Marks a connection ID as failed

network-libp2p/src/network_metrics.rs

@@ -18,11 +18,6 @@ struct TopicLabels {
     topic: String,
 }
 
-#[derive(Clone, Debug, Hash, PartialEq, Eq, EncodeLabelSet)]
-struct RequestIdLabels {
-    request_id: String,
-}
-
 impl Default for NetworkMetrics {
     fn default() -> Self {
         NetworkMetrics {

network-mock/src/network.rs

@@ -392,7 +392,7 @@ impl MockNetwork {
         }
     }
 
-    async fn publish_with_name<T: Topic>(
+    async fn publish_with_name<T>(
         &self,
         topic_name: String,
         item: T::Item,

utils/src/merkle/mod.rs

@@ -241,40 +241,6 @@ impl<'de, H: HashOutput> Deserialize<'de> for MerklePath<H> {
         )
     }
 }
-struct MerklePathNodesVisitor<H: HashOutput> {
-    left_bits: Vec<u8>,
-    count: usize,
-    phantom: PhantomData<H>,
-}
-
-impl<'de, H: HashOutput> Visitor<'de> for MerklePathNodesVisitor<H> {
-    type Value = Vec<MerklePathNode<H>>;
-
-    fn expecting(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
-        write!(f, "a set Merkle Path nodes")
-    }
-
-    fn visit_seq<A>(self, mut seq: A) -> Result<Vec<MerklePathNode<H>>, A::Error>
-    where
-        A: SeqAccess<'de>,
-    {
-        let mut nodes: Vec<MerklePathNode<H>> = Vec::with_capacity(self.count);
-        let mut curr = 0usize;
-        while let Some(hash) = seq.next_element::<H>()? {
-            nodes.push(MerklePathNode {
-                left: MerklePath::<H>::decompress(curr, &self.left_bits),
-                hash,
-            });
-            curr += 1;
-            if curr > self.count {
-                return Err(A::Error::custom(
-                    "Size mismatch for a set of MerklePath nodes",
-                ));
-            }
-        }
-        Ok(nodes)
-    }
-}
 
 pub type Blake2bMerklePath = MerklePath<Blake2bHash>;
 

validator/src/aggregation/tendermint/state.rs

@@ -142,22 +142,6 @@ impl MacroState {
     }
 }
 
-struct State<TValidatorNetwork: ValidatorNetwork + 'static>(
-    pub u32,
-    pub TendermintState<TendermintProtocol<TValidatorNetwork>>,
-)
-where
-    PubsubId<TValidatorNetwork>: std::fmt::Debug + Unpin;
-
-impl<TValidatorNetwork: ValidatorNetwork + 'static> Clone for State<TValidatorNetwork>
-where
-    PubsubId<TValidatorNetwork>: std::fmt::Debug + Unpin,
-{
-    fn clone(&self) -> Self {
-        Self(self.0, self.1.clone())
-    }
-}
-
 impl IntoDatabaseValue for MacroState {
     fn database_byte_size(&self) -> usize {
         self.serialized_size()

zkp/src/verifying_key.rs

@@ -8,6 +8,7 @@ use nimiq_zkp_circuits::metadata::VerifyingKeyMetadata;
 use nimiq_zkp_primitives::VerifyingData;
 use once_cell::sync::OnceCell;
 
+#[derive(Default)]
 pub struct ZKPVerifyingKey {
     cell: OnceCell<VerifyingData>,
 }