Skip to content
This repository was archived by the owner on May 2, 2021. It is now read-only.

Commit 3541f1c

Browse files
authored
Merge pull request #47 from no23reason/features/remove-size-prop
Remove 'size' prop
2 parents 52f16eb + f6fd89d commit 3541f1c

9 files changed

Lines changed: 23 additions & 34 deletions

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ The props available are (shown with default values):
5050
```js
5151
{
5252
value: '', // The value to encode in the code
53-
size: 256, // Size of the code in pixels. This is obsolete and will be removed in the next major version!
5453
level: 'L', // QR Error correction level
5554
bgColor: '#FFFFFF', // Color of the bright squares
5655
fgColor: '#000000', // Color of the dark squares

demo/Demo.jsx

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,19 @@ class Demo extends React.Component {
66
super(props, context);
77
this.state = {
88
value: 'Try changing the values and see the code update in real-time!',
9-
size: 256,
109
level: 'L',
1110
bgColor: '#FFFFFF',
1211
fgColor: '#000000',
1312
};
1413
}
1514

1615
updateValue = e => this.setState({ ...this.state, value: e.target.value });
17-
updateSize = e => this.setState({ ...this.state, size: +(e.target.value) });
1816
updateLevel = e => this.setState({ ...this.state, level: e.target.value });
1917
updateBgColor = e => this.setState({ ...this.state, bgColor: e.target.value });
2018
updateFgColor = e => this.setState({ ...this.state, fgColor: e.target.value });
2119

2220
render() {
23-
const { state, updateSize, updateValue, updateLevel, updateBgColor, updateFgColor } = this;
21+
const { state, updateValue, updateLevel, updateBgColor, updateFgColor } = this;
2422
return (<div>
2523
<form className="pure-form pure-form-stacked">
2624
<fieldset>
@@ -29,26 +27,22 @@ class Demo extends React.Component {
2927
<label htmlFor="value">Value</label>
3028
<textarea className="pure-input-1" id="value" onChange={updateValue} type="text" value={state.value} />
3129
</div>
32-
<div className="pure-u-1-4"><label htmlFor="level">Level</label>
30+
<div className="pure-u-1-3"><label htmlFor="level">Level</label>
3331
<select id="level" onChange={updateLevel}>
3432
<option value="L">L</option>
3533
<option value="M">M</option>
3634
<option value="Q">Q</option>
3735
<option value="H">H</option>
3836
</select>
3937
</div>
40-
<div className="pure-u-1-4">
38+
<div className="pure-u-1-3">
4139
<label htmlFor="fgColor">Foregroud</label>
4240
<input id="fgColor" onChange={updateFgColor} type="color" value={state.fgColor} />
4341
</div>
44-
<div className="pure-u-1-4">
42+
<div className="pure-u-1-3">
4543
<label htmlFor="bgColor">Background</label>
4644
<input id="bgColor" onChange={updateBgColor} type="color" value={state.bgColor} />
4745
</div>
48-
<div className="pure-u-1-4">
49-
<label htmlFor="size">Size</label>
50-
<input className="pure-input-1" id="size" onChange={updateSize} type="number" value={state.size} />
51-
</div>
5246
</div>
5347
</fieldset>
5448
</form>
@@ -57,7 +51,7 @@ class Demo extends React.Component {
5751
bgColor={state.bgColor}
5852
fgColor={state.fgColor}
5953
level={state.level}
60-
style={{ width: state.size }}
54+
style={{ width: 500 }}
6155
value={state.value}
6256
/>
6357
</div>

docs/app.5772cf807213db8998c7.js

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/app.9f75ed5a44b04282b735.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

docs/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,5 @@ <h1>react-qr-svg</h1>
4747
</section>
4848
</article>
4949
</div>
50-
<script type="text/javascript" src="manifest.13035e058901d5ab0fde.js"></script><script type="text/javascript" src="vendors.f5af5a37821b3505a0eb.js"></script><script type="text/javascript" src="app.9f75ed5a44b04282b735.js"></script><script type="text/javascript" src="style.0f46ed9cbf5e2764169e.js"></script></body>
50+
<script type="text/javascript" src="manifest.ed3ef8faf5a8845e0785.js"></script><script type="text/javascript" src="vendors.f5af5a37821b3505a0eb.js"></script><script type="text/javascript" src="app.5772cf807213db8998c7.js"></script><script type="text/javascript" src="style.0f46ed9cbf5e2764169e.js"></script></body>
5151
</html>

docs/manifest.13035e058901d5ab0fde.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

docs/manifest.ed3ef8faf5a8845e0785.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

index.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ interface QRCodeProps {
55
* The value to encode in the code
66
*/
77
value: string;
8-
/**
9-
* Size of the code in pixels
10-
*/
11-
size?: number;
128
/**
139
* QR Error correction level
1410
*/

tests/typescript/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ interface IDemoProps {
88
class Demo extends React.Component<IDemoProps, {}> {
99
render(): React.ReactElement<{}> {
1010
return <div>
11-
<QRCode bgColor="#FFFFFF" fgColor="#000000" level="M" size={512} value={this.props.text} />
11+
<QRCode bgColor="#FFFFFF" fgColor="#000000" level="M" value={this.props.text} />
1212
<QRCode value="Only value here" />
1313
<QRCode value="Style here" style={{ width: 250 }} />
1414
</div>;

0 commit comments

Comments
 (0)