Skip to content

Duplicate before_install_package in Node 20 definitions shadows EOL warning #1101

@valerie-stoica

Description

@valerie-stoica

In share/node-build/20.x-dev (and individual 20.x release files), before_install_package is defined twice in sequence — the first calls build_package_warn_eol, the second calls build_package_warn_lts_maintenance and shadows the first, so the EOL warning is unreachable for Node 20 installs (which are EOL as of 2026-04-30).

Surfaced during a downstream vendor sync at Shopify: https://github.com/Shopify/shopify-build/pull/9132.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions