Skip to content

Commit 2c79fa3

Browse files
authored
Merge pull request #5600 from nodetool-ai/claude/codebase-audit-web-packages-riugl4
refactor: remove duplicated and dead code found by the codebase slop audit
2 parents 2b18e10 + ac52ec9 commit 2c79fa3

670 files changed

Lines changed: 15789 additions & 34437 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs/cli.md

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,6 +1001,10 @@ Query job status and results. Reads the local database by default.
10011001
- `--limit <n>` — max results (default: `100`).
10021002
- `--json` — output as JSON.
10031003

1004+
`--json` returns the same declared row shape whether the command read the local
1005+
database or a server. The local read used to dump every column, including a
1006+
job's whole `graph` and `logs`.
1007+
10041008
**Examples:**
10051009

10061010
```bash
@@ -1596,8 +1600,8 @@ The file lives in the user config directory, not the working directory:
15961600
than guessing the path.
15971601

15981602
**Subcommands:** `init`, `add`, `edit`, `list`, `show`, `plan`, `apply`,
1599-
`status`, `logs`, `destroy`, plus the remote groups `workflows`, `database`,
1600-
`collections` and the `users-*` verbs below.
1603+
`status`, `logs`, `destroy`, plus the remote group `workflows` and the
1604+
`users-*` verbs below.
16011605

16021606
**Options:**
16031607

@@ -1645,33 +1649,22 @@ create it.`
16451649
The full server walkthrough is [Deployment](deployment.md) and
16461650
[Self-Hosted Deployment](self-hosted-deployment.md).
16471651

1648-
#### Remote workflows, rows, and collections
1652+
#### Remote workflows
16491653

1650-
Once a target is up, three groups act on it over the admin API rather than on
1651-
the local database:
1654+
Once a target is up, `workflows` acts on the deployment's `/api/workflows`
1655+
routes rather than on the local database:
16521656

16531657
```bash
1654-
# Push a local workflow and everything it references, then run it there
1658+
# Push a local workflow to the deployment, then run it there
16551659
nodetool deploy workflows sync my-server <workflow_id>
16561660
nodetool deploy workflows list my-server
16571661
nodetool deploy workflows run my-server <workflow_id> -p prompt="a red fox"
16581662
nodetool deploy workflows delete my-server <workflow_id>
1659-
1660-
# Read, upsert, and delete a single remote DB row
1661-
nodetool deploy database get my-server users alice
1662-
nodetool deploy database save my-server users '{"id":"alice","role":"admin"}'
1663-
nodetool deploy database delete my-server users alice
1664-
1665-
# Push a local RAG collection to the deployment
1666-
nodetool deploy collections sync my-server my_docs
16671663
```
16681664

1669-
`workflows run` takes `-p, --param <k=v>`, repeatable. `<table>` is passed
1670-
through to the deployment, which resolves it against its own adapters — the
1671-
valid names are the remote server's tables, not a list this CLI holds. `save`
1672-
takes the row as a positional JSON string, and `get` on a row that is not there
1673-
answers `404`. `collections sync` uploads in batches of `--batch-size`,
1674-
default `100`.
1665+
`workflows run` takes `-p, --param <k=v>`, repeatable. `sync` pushes the
1666+
workflow row itself; the assets and models its nodes reference must already be
1667+
present on the target.
16751668

16761669
#### API users on the deployment
16771670

@@ -1686,7 +1679,7 @@ nodetool deploy users-remove my-server alice
16861679
```
16871680

16881681
Every subcommand that touches a live deployment — the `users-*` verbs and the
1689-
three remote groups above — sends an admin bearer token. `--token <token>`
1682+
`workflows` group above — sends an admin bearer token. `--token <token>`
16901683
passes it explicitly and wins over `NODETOOL_ADMIN_TOKEN`; with neither, an
16911684
interactive shell prompts and a non-interactive one exits `1`.
16921685

docs/developer/custom-nodes-guide.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,10 +438,12 @@ Always prefer `getSecret` over `process.env` — secrets are user-scoped and may
438438
const resp = await context.httpGet("https://api.example.com/data", {
439439
headers: { Authorization: `Bearer ${apiKey}` }
440440
});
441-
await context.httpPost(url, { json: { foo: 1 } });
442-
// Also: httpPut, httpPatch, httpDelete, httpHead
441+
await context.httpRequestWithRetries("POST", url, { json: { foo: 1 } });
443442
```
444443

444+
`httpGet` is the GET shorthand. Every other verb goes through
445+
`httpRequestWithRetries`, which carries the shared retry and backoff policy.
446+
445447
### Cache
446448

447449
The per-job cache is exposed at `context.cache`. Both methods are **async**;

docs/failure-mode-roadmap.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,9 @@ Run the case on Windows; a Windows-style string on macOS is not sufficient.
170170

171171
### 7C. Dialog containment audit
172172

173-
`PositionedDialog` already clamps to the viewport. Enumerate other dialog
174-
primitives and direct users in a checked-in audit with a non-zero count. A
173+
No dialog primitive clamps to the viewport today — `PositionedDialog`, which
174+
did, is deleted. Enumerate the dialog primitives and direct users in a
175+
checked-in audit with a non-zero count. A
175176
dialog fails the audit when its rendered bounds extend outside a 600 x 600 px
176177
viewport or its content cannot scroll into view. Migrate failing callers and
177178
add one 600 x 600 px test per migrated primitive.

docs/plans/ui-primitives-overhaul.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ into the Fix 1 sweep):
8686
| `WarningBanner.tsx:73` | `border-radius: 8px` |
8787
| `Breadcrumbs.tsx:56` | `border-radius: 4px` |
8888
| `ZoomControls.tsx:34` | `minWidth: "45px"` — off-grid |
89-
| `InfoTooltip.tsx:77` | `font-size: 14px` — off the type scale |
9089
| `NotificationBadge.tsx:56` | `font-size: 10px` — off the type scale |
9190

9291
### 2.2 Unrelated defaults across primitives
@@ -416,7 +415,7 @@ props); every existing screen improves without migration. Each PR:
416415
`SelectField`, `SearchInput`, `TagInput`.
417416
3. Off-grid sweep: `Slider`, `NodeSlider`, `Panel` padding, plus the ⚠ table
418417
in 2.1 (TabGroup, Chip, UndoRedoButtons, MenuItemPrimitive,
419-
MobileBottomSheet, WarningBanner, Breadcrumbs, ZoomControls, InfoTooltip,
418+
MobileBottomSheet, WarningBanner, Breadcrumbs, ZoomControls,
420419
NotificationBadge).
421420
4. Add a `DesignTokens.Control` Storybook story (heights/paddings/radius
422421
swatches) next to the existing `DesignTokens.*` stories.

docs/url-egress-inventory.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ Everything here fetches a URL somebody else chose, through the protected fetch.
9696
| OpenAI media input | `packages/llm-nodes/src/nodes/openai.ts` | workflow |
9797
| Together asset resolution | `packages/together-nodes/src/together-base.ts` | workflow |
9898
| AtlasCloud media pass-through | `packages/atlascloud-nodes/src/atlascloud-factory.ts` | workflow |
99+
| AtlasCloud prediction downloads | `packages/runtime/src/providers/atlascloud-transport.ts` | provider response |
99100
| KIE result downloads | `packages/kie-nodes/src/kie-base.ts` | provider response |
100101
| Topaz result downloads | `packages/topaz-nodes/src/topaz-base.ts` | provider response |
101102
| MiniMax audio / file downloads | `packages/minimax-nodes/src/minimax-base.ts` | provider response |

0 commit comments

Comments
 (0)