Merge pull request #5291 from nodetool-ai/fix-n-plus-1-workflow-version-prune-4513421338717948883

Bolt: fix N+1 query when pruning workflow versions

Author: georgi

.jules/bolt.md

@@ -99,3 +99,6 @@
 ## 2026-05-25 - O(N*C^2) mapping optimization in TableActions paste operation
 **Learning:** Found an $O(N \times C^2)$ performance bottleneck in `web/src/components/node/DataTable/TableActions.tsx` when pasting large sets of data into the DataTable. For every column in every row, the code looped over `columnMapping.entries()` (which is size $C$) to find the corresponding paste column index.
 **Action:** Replaced the paste column index lookup via `Map.entries()` iteration with a pre-computed `$O(1)$` lookup. By inverting the map from `columnMapping` to `dfIdxToPasteIdx` (mapping dataframe column index to pasted index), the time complexity of pasting data is reduced to $O(N \times C)$.
+## 2026-05-25 - N+1 query optimization in pruneOldAutosaves
+**Learning:** Found an N+1 query bottleneck in `packages/models/src/workflow-version.ts` where `v.delete()` was called inside a loop over the oldest autosave versions. For workflows with many excess autosaves (e.g. 1500), doing 1500 sequential `DELETE` queries took ~392ms.
+**Action:** Replaced the sequential deletes with batched `DELETE WHERE id IN (...)` queries (using `inArray` from Drizzle) grouped in chunks of 500 to satisfy SQLite query limits. This reduced the time to prune 1500 versions to ~18ms, a significant speedup.

packages/models/src/workflow-version.ts

@@ -2,7 +2,7 @@
  * WorkflowVersion model – stores versioned snapshots of workflow graphs.
  */
 
-import { eq, and, desc } from "drizzle-orm";
+import { eq, and, desc, inArray } from "drizzle-orm";
 import { DBModel, createTimeOrderedUuid } from "./base-model.js";
 import { getDb } from "./db.js";
 import { workflowVersions } from "./schema/workflow-versions.js";
@@ -91,7 +91,7 @@ export class WorkflowVersion extends DBModel {
   ): Promise<void> {
     const db = getDb();
     const rows = await db
-      .select()
+      .select({ id: workflowVersions.id })
       .from(workflowVersions)
       .where(
         and(
@@ -101,11 +101,16 @@ export class WorkflowVersion extends DBModel {
       )
       .orderBy(desc(workflowVersions.version));
     if (rows.length <= maxAutosaves) return;
-    const toDelete = rows
+    const toDeleteIds = rows
       .slice(Math.max(0, maxAutosaves))
-      .map((row: Record<string, unknown>) => new WorkflowVersion(row));
-    for (const v of toDelete) {
-      await v.delete();
+      .map((row) => row.id);
+
+    // chunk IDs to avoid SQLite limits
+    for (let i = 0; i < toDeleteIds.length; i += 500) {
+      const chunk = toDeleteIds.slice(i, i + 500);
+      await db
+        .delete(workflowVersions)
+        .where(inArray(workflowVersions.id, chunk));
     }
   }
 }