fix: preserve Personal project ownership

Author: Sprite

packages/models/src/project.ts

@@ -314,6 +314,18 @@ export class Project extends DBModel {
     id: string,
     fields: Partial<{ name: string; kind: string; thread_id: string }>
   ): Promise<Project | null> {
+    const existing = await Project.findOwned(userId, id);
+    if (!existing) return null;
+    // Personal is a permanent account space. Keep its marker immutable, and
+    // do not let a named project be converted into the reserved kind.
+    if (
+      fields.kind !== undefined &&
+      fields.kind !== existing.kind &&
+      (existing.kind === PERSONAL_PROJECT_KIND ||
+        fields.kind === PERSONAL_PROJECT_KIND)
+    ) {
+      return null;
+    }
     const db = getDb();
     const rows = await db
       .update(projects)

packages/models/tests/project.test.ts

@@ -108,6 +108,28 @@ describe("Project model", () => {
     expect(updated!.updated_at > "2020-01-01T00:00:00.000Z").toBe(true);
   });
 
+  it("keeps Personal permanently personal", async () => {
+    const personal = await Project.ensurePersonal("u1");
+    expect(
+      await Project.updateOwned("u1", personal.id, { kind: "campaign" })
+    ).toBeNull();
+    expect((await Project.findById(personal.id))?.kind).toBe(
+      PERSONAL_PROJECT_KIND
+    );
+
+    const named = await Project.create<Project>({
+      user_id: "u1",
+      name: "Campaign",
+      kind: "campaign"
+    });
+    expect(
+      await Project.updateOwned("u1", named.id, {
+        kind: PERSONAL_PROJECT_KIND
+      })
+    ).toBeNull();
+    expect((await Project.findById(named.id))?.kind).toBe("campaign");
+  });
+
   it("deletes the project and moves its documents back to the loose bucket", async () => {
     const project = await Project.create<Project>({ user_id: "u1", name: "Aurora" });
     const board = await Storyboard.create<Storyboard>({