Merge pull request #5498 from nodetool-ai/claude/m1-sub-agents-51bghx

Author: georgi

electron/src/__tests__/verifyBackendBundle.test.ts

@@ -68,6 +68,7 @@ function writeValidBundle(dir: string): void {
   );
   writeShippedSandboxPacks(dir);
   writeShippedSystemSkills(dir);
+  writeShippedFonts(dir);
   fs.mkdirSync(path.join(dir, "js-sandbox-worker"), { recursive: true });
   fs.writeFileSync(
     path.join(dir, "js-sandbox-worker", "worker-entry.js"),
@@ -98,6 +99,16 @@ const SANDBOX_PACKS_DIR = path.join(
   "sandbox-packs"
 );
 
+const FONTS_DIR = path.join(
+  __dirname,
+  "..",
+  "..",
+  "..",
+  "packages",
+  "timeline",
+  "fonts"
+);
+
 const SYSTEM_SKILLS_DIR = path.join(
   __dirname,
   "..",
@@ -156,6 +167,23 @@ function writeShippedSystemSkills(dir: string): void {
   }
 }
 
+/**
+ * Stage every bundled font file the repo ships.
+ *
+ * Same reason as the packs and skills above: the script cross-checks the
+ * staged set against `packages/timeline/fonts/` inside a checkout, so a
+ * fixture staging none of them is an incomplete bundle. The bytes are a stub —
+ * what the check reads is presence, and no face is parsed here.
+ */
+function writeShippedFonts(dir: string): void {
+  const fontDir = path.join(dir, "fonts");
+  fs.mkdirSync(fontDir, { recursive: true });
+  for (const entry of fs.readdirSync(FONTS_DIR)) {
+    if (!/\.(ttf|otf|txt)$/i.test(entry)) continue;
+    fs.writeFileSync(path.join(fontDir, entry), "x");
+  }
+}
+
 function writeStagedPackage(
   dir: string,
   name: string,
@@ -383,6 +411,37 @@ describe("verify-backend-bundle", () => {
     expect(output).toContain(`system skills staged: ${staged}`);
   });
 
+  // C6, and the check T17 was required to observe failing: the packaged
+  // backend registers these faces before it draws a title, so an unstaged one
+  // silently renders every clip in that family in a host font.
+  it("fails when a bundled font file is not staged", () => {
+    const fonts = fs.readdirSync(path.join(tempDir, "fonts")).sort();
+    expect(fonts).toContain("BebasNeue-Regular.ttf");
+    fs.rmSync(path.join(tempDir, "fonts", "BebasNeue-Regular.ttf"));
+    const { status, output } = runVerify(tempDir);
+    expect(status).toBe(1);
+    expect(output).toContain("Bundled font file(s) not staged under fonts/");
+    expect(output).toContain("BebasNeue-Regular.ttf");
+  });
+
+  // A face without its licence is a licensing failure, not a cosmetic one
+  // (C7), so the OFL files are checked with the faces rather than beside them.
+  it("fails when a font licence is not staged", () => {
+    fs.rmSync(path.join(tempDir, "fonts", "OFL-Inter.txt"));
+    const { status, output } = runVerify(tempDir);
+    expect(status).toBe(1);
+    expect(output).toContain("OFL-Inter.txt");
+  });
+
+  it("reports the bundled font files it found", () => {
+    const { status, output } = runVerify(tempDir);
+    expect(status).toBe(0);
+    // A count, so the check cannot pass by having matched nothing.
+    const staged = fs.readdirSync(path.join(tempDir, "fonts")).length;
+    expect(staged).toBeGreaterThan(0);
+    expect(output).toContain(`${staged} bundled font file(s) staged`);
+  });
+
   it("fails when server.mjs itself is missing", () => {
     fs.rmSync(path.join(tempDir, "server.mjs"));
     const { status, output } = runVerify(tempDir);

package-lock.json

@@ -73,6 +73,7 @@
     "turndown": "^7.2.2"
   },
   "devDependencies": {
+    "@nodetool-ai/video-nodes": "*",
     "@stryker-mutator/core": "^9.6.1",
     "@stryker-mutator/vitest-runner": "^9.6.1",
     "@types/chrome-remote-interface": "^0.33.0",

packages/agents/package.json

@@ -353,6 +353,72 @@ export const editTimelineSpec: CapabilitySpec = {
   }
 };
 
+export const SET_TIMELINE_DOCUMENT_SCHEMA: JsonSchema = {
+  type: "object",
+  properties: {
+    timeline_id: {
+      type: "string",
+      description: "Timeline sequence id (from list_timelines)."
+    },
+    document: {
+      type: "object",
+      description:
+        "The whole document to store: {tracks, clips, markers, transcript?, " +
+        "scriptEnabled?}. It replaces the stored one field for field, so " +
+        "anything you leave out is dropped — read the current document with " +
+        "get_timeline and send it back changed, rather than sending only the " +
+        "part you edited. `markers` may be omitted and defaults to an empty " +
+        "list."
+    },
+    fps: {
+      type: "number",
+      description:
+        "Frame rate to store with the sequence. Omit to keep the current one."
+    },
+    width: {
+      type: "number",
+      description: "Render width. Omit to keep the current one."
+    },
+    height: {
+      type: "number",
+      description: "Render height. Omit to keep the current one."
+    },
+    expected_updated_at: {
+      type: "string",
+      description:
+        "The `updated_at` the document was read at. When it no longer " +
+        "matches the stored row the write is refused as a conflict instead " +
+        "of overwriting whoever changed it in between."
+    },
+    snapshot_name: {
+      type: "string",
+      description:
+        "Label for the snapshot taken before the write, e.g. 'before the " +
+        "title pass'."
+    }
+  },
+  required: ["timeline_id", "document"]
+};
+
+export const setTimelineDocumentSpec: CapabilitySpec = {
+  name: "set_timeline_document",
+  description:
+    "Write a whole timeline document at once — every track, clip, marker and " +
+    "animation in one call, instead of a script of edit_timeline ops. Reach " +
+    "for it when you are authoring a cut from scratch or restructuring one " +
+    "wholesale; edit_timeline stays the better tool for a few targeted " +
+    "changes to a cut that already exists. The document is validated before " +
+    "anything is written: errors refuse the write and come back as issues, " +
+    "so a document that would not render never reaches the sequence. The " +
+    "state it replaces is snapshotted as a manual version first, so the " +
+    "write is undoable with restore_timeline_version, and the validation of " +
+    "what actually landed is returned with the result.",
+  inputSchema: SET_TIMELINE_DOCUMENT_SCHEMA,
+  category: "write",
+  userMessage: (params) =>
+    `Writing the document of timeline ${String(params["timeline_id"])}`
+};
+
 export const validateTimelineSpec: CapabilitySpec = {
   name: "validate_timeline",
   description:
@@ -473,6 +539,7 @@ export const timelinesSpecs: readonly CapabilitySpec[] = [
   deleteTimelineVersionSpec,
   editTimelineSpec,
   validateTimelineSpec,
+  setTimelineDocumentSpec,
   previewTimelineFrameSpec,
   deleteTimelineSpec
 ];