Merge branch 'master' of https://github.com/noir-lang/noir into jf/method-attrs

Author: jfecher

.github/critical_libraries_status/noir-lang/keccak256/.failures.jsonl

@@ -1,4 +1,5 @@
 {"suite":"keccak256","name":"keccak256::oracle_tests::test_keccak256_1"}
 {"suite":"keccak256","name":"keccak256::oracle_tests::test_keccak256_100"}
 {"suite":"keccak256","name":"keccak256::oracle_tests::test_keccak256_135"}
+{"suite":"keccak256","name":"keccak256::oracle_tests::test_keccak256_136"}
 {"suite":"keccak256","name":"keccak256::oracle_tests::test_keccak256_256"}

.github/scripts/extract-fuzz-seeds.sh

@@ -0,0 +1,47 @@
+#!/bin/bash
+set -eu
+
+# Usage: ./extract-fuzz-seeds.sh <fuzz-output.log> [output-dir]
+#
+# Parses a captured `cargo nextest run -p noir_ast_fuzzer_fuzz` log and writes:
+#   <output-dir>/seeds.txt          — one deduplicated 0x... seed per line
+#   <output-dir>/seeds-by-test.tsv  — "<nextest FAIL line>\t<seed>" pairs
+#
+# Recognises both the arbtest panic line (e.g. "    Seed: 0x6819c61400001000")
+# and the explicit repro env var (e.g. "NOIR_AST_FUZZER_SEED=0x6819c61400001000").
+
+if [ $# -lt 1 ] || [ $# -gt 2 ]; then
+    echo "Usage: $0 <fuzz-output.log> [output-dir]" >&2
+    exit 2
+fi
+
+log_file=$1
+out_dir=${2:-.}
+
+if [ ! -f "$log_file" ]; then
+    echo "error: log file not found: $log_file" >&2
+    exit 1
+fi
+
+mkdir -p "$out_dir"
+seeds_file="$out_dir/seeds.txt"
+by_test_file="$out_dir/seeds-by-test.tsv"
+
+# nextest emits ANSI color escapes even when stdout is a pipe, so any log
+# captured via `tee` contains CSI sequences like \x1b[31;1m wrapping seeds and
+# `FAIL` markers. Strip them up-front so the downstream patterns can match.
+cleaned_log=$(mktemp)
+trap 'rm -f "$cleaned_log"' EXIT
+sed -E $'s/\x1b\\[[0-9;?]*[ -/]*[@-~]//g' "$log_file" > "$cleaned_log"
+
+grep -hoE '(Seed:[[:space:]]*0x[0-9a-fA-F]+|NOIR_AST_FUZZER_SEED=0x[0-9a-fA-F]+)' "$cleaned_log" \
+    | grep -oE '0x[0-9a-fA-F]+' \
+    | sort -u > "$seeds_file" || true
+
+awk '
+    /^[[:space:]]*FAIL / { current = $0 }
+    /Seed:[[:space:]]*0x[0-9a-fA-F]+/ {
+        match($0, /0x[0-9a-fA-F]+/); seed = substr($0, RSTART, RLENGTH);
+        print current "\t" seed
+    }
+' "$cleaned_log" > "$by_test_file" || true

.github/workflows/nightly-fuzz-test.yml

@@ -33,11 +33,37 @@ jobs:
       - uses: taiki-e/install-action@just
 
       - name: Run fuzzer
-        run: just fuzz-nightly
+        id: fuzz
+        shell: bash
+        run: |
+          set -o pipefail
+          just fuzz-nightly 2>&1 | tee fuzz-output.log
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           RUST_MIN_STACK: 8388608
 
+      - name: Extract fuzzer seeds
+        if: failure()
+        id: seeds
+        shell: bash
+        run: |
+          ./.github/scripts/extract-fuzz-seeds.sh fuzz-output.log .
+          seed_count=$(wc -l < seeds.txt | tr -d ' ')
+          seeds=$(paste -sd, - < seeds.txt)
+          echo "seed_count=${seed_count}" >> "$GITHUB_OUTPUT"
+          echo "seeds=${seeds}" >> "$GITHUB_OUTPUT"
+
+      - name: Upload fuzz failure artifact
+        if: failure()
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
+        with:
+          name: nightly-fuzz-failure
+          path: |
+            fuzz-output.log
+            seeds.txt
+            seeds-by-test.tsv
+          retention-days: 30
+
       - name: Get current date
         id: date
         run: echo "DAY=date::$(date +'%u')" >> $GITHUB_OUTPUT
@@ -51,3 +77,6 @@ jobs:
           webhook-type: webhook-trigger
           payload: |
             workflow-url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+            seed-count: ${{ steps.seeds.outputs.seed_count }}
+            seeds: ${{ steps.seeds.outputs.seeds }}
+            artifact-name: nightly-fuzz-failure

.github/workflows/publish-nightly.yml

@@ -14,7 +14,7 @@ jobs:
       contents: read
     steps:
       - name: Dispatch to publish-nargo
-        uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4 # v1
+        uses: benc-uk/workflow-dispatch@31e2b3319479a63f0ab15bf800eff9e913504e26 # v1
         with:
           workflow: publish-nargo.yml
           token: ${{ secrets.NOIR_REPO_TOKEN }}
@@ -23,7 +23,7 @@ jobs:
 
 
       - name: Dispatch to publish-es-packages
-        uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4 # v1
+        uses: benc-uk/workflow-dispatch@31e2b3319479a63f0ab15bf800eff9e913504e26 # v1
         with:
           workflow: publish-es-packages.yml
           token: ${{ secrets.NOIR_REPO_TOKEN }}

.github/workflows/release.yml

@@ -211,7 +211,7 @@ jobs:
       contents: read
     steps:
       - name: Dispatch to publish workflow
-        uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4 # v1
+        uses: benc-uk/workflow-dispatch@31e2b3319479a63f0ab15bf800eff9e913504e26 # v1
         with:
           workflow: publish-nargo.yml
           repo: noir-lang/noir
@@ -228,7 +228,7 @@ jobs:
       contents: read
     steps:
       - name: Dispatch to publish-es-packages
-        uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4 # v1
+        uses: benc-uk/workflow-dispatch@31e2b3319479a63f0ab15bf800eff9e913504e26 # v1
         with:
           workflow: publish-es-packages.yml
           ref: master
@@ -245,7 +245,7 @@ jobs:
 
     steps:
       - name: Dispatch to publish-acvm
-        uses: benc-uk/workflow-dispatch@7a027648b88c2413826b6ddd6c76114894dc5ec4 # v1
+        uses: benc-uk/workflow-dispatch@31e2b3319479a63f0ab15bf800eff9e913504e26 # v1
         with:
           workflow: publish-acvm.yml
           ref: master

CLAUDE.md

@@ -235,6 +235,10 @@ Special labels to control CI behavior:
 
   - Use when you think that the PR will result in improvements/degradation of compilation time or memory usage.
 
+### GitHub Actions
+
+Third-party actions in `.github/workflows/` are pinned by full commit SHA with the human-readable version in a trailing comment, e.g. `uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7`. When updating an action, rewrite the reference to the new commit SHA rather than a mutable `@vN` tag, and keep the `# vN` comment in sync.
+
 ### Workflow Reminders
 
 - ✅ Always compile before testing

Cargo.lock

@@ -106,6 +106,11 @@ implicit_clone = "warn"
 map_unwrap_or = "warn"
 needless_borrows_for_generic_args = "warn"
 redundant_field_names = "warn"
+while_let_loop = "warn"
+for_kv_map = "warn"
+iter_kv_map = "warn"
+unnecessary_sort_by = "warn"
+useless_conversion = "warn"
 
 [workspace.dependencies]
 

Cargo.toml

@@ -46,7 +46,7 @@ libraries:
     critical: false
   noir_json_parser:
     repo: noir-lang/noir_json_parser
-    timeout: 16
+    timeout: 17
     critical: false
   sha256:
     repo: noir-lang/sha256
@@ -67,13 +67,13 @@ libraries:
     repo: AztecProtocol/aztec-packages
     ref: *AZ_COMMIT
     path: noir-projects/aztec-nr
-    timeout: 260
+    timeout: 280
     critical: false
   noir_contracts:
     repo: AztecProtocol/aztec-packages
     ref: *AZ_COMMIT
     path: noir-projects/noir-contracts
-    timeout: 230
+    timeout: 250
     critical: false
   blob:
     repo: AztecProtocol/aztec-packages
@@ -85,7 +85,7 @@ libraries:
     repo: AztecProtocol/aztec-packages
     ref: *AZ_COMMIT
     path: noir-projects/noir-protocol-circuits/crates/private-kernel-lib
-    timeout: 550
+    timeout: 620
     critical: false
   protocol_circuits_types:
     repo: AztecProtocol/aztec-packages

EXTERNAL_NOIR_LIBRARIES.yml

@@ -141,7 +141,7 @@ impl<F> Expression<F> {
             }
         }
         self.mul_terms.sort_by(|a, b| a.1.cmp(&b.1).then(a.2.cmp(&b.2)));
-        self.linear_combinations.sort_by(|a, b| a.1.cmp(&b.1));
+        self.linear_combinations.sort_by_key(|a| a.1);
     }
 
     #[cfg(test)]