Skip to content

Move run.sh into the scripts folder #57

Description

@Savio-Sou

Problem

Noir's main respository test script check-critical-libraries.sh currently scans for library test scripts in their scripts folder.

This repository's run.sh living in a different folder (i.e. fuzz_test) causes its oracle tests to fail when running through the Noir main repository test script:

--- oracle_test::test_oracle_standard_encoding stdout ---
Execution failed: Failed assertion: 0 output values were provided as a foreign call result for 1 destination slots
Failing input: {"input":["0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00"]}
error: Assertion failed: '0 output values were provided as a foreign call result for 1 destination slots'
   ┌─ src/oracle_test.nr:31:5
   │
31 │     node_base64_encode_standard(input)
   │     ----------------------------------
   │
   = Call stack:
     1: test_oracle_standard_encoding
             at src/oracle_test.nr:73:18
     2: test_oracle_standard
             at src/oracle_test.nr:49:25
     3: get_node_standard_encode
             at src/oracle_test.nr:31:5

---------------------------------------------------------
--- oracle_test::test_oracle_url_safe_encoding stdout ---
Execution failed: Failed assertion: 0 output values were provided as a foreign call result for 1 destination slots
Failing input: {"input":["0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00","0x00"]}
error: Assertion failed: '0 output values were provided as a foreign call result for 1 destination slots'
   ┌─ src/oracle_test.nr:39:5
   │
39 │     node_base64_encode_url_safe(input)
   │     ----------------------------------
   │
   = Call stack:
     1: test_oracle_url_safe_encoding
             at src/oracle_test.nr:81:18
     2: test_oracle_url_safe
             at src/oracle_test.nr:61:25
     3: get_node_url_safe_encode
             at src/oracle_test.nr:39:5

---------------------------------------------------------

[noir_base64] Failures:
     oracle_test::test_oracle_standard_encoding
     oracle_test::test_oracle_url_safe_encoding

[noir_base64] 46 tests passed, 2 tests failed

Happy Case

Move the run.sh script into the scripts folder instead, with tweaks where necessary.

Workaround

No response

Would you like to submit a PR for this Issue?

Yes

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions