feat: return stale value when fetch error

Author: 9romise

src/utils/cache.ts

@@ -4,7 +4,7 @@ import { LRUCache } from 'lru-cache'
 
 export function createCachedFetch<T extends object>(
   key: string,
-  fetchMethod: (name: string, staleValue: T | undefined, options: LRUCache.FetcherOptions<string, T, unknown>) => Promise<T | undefined>,
+  fetchMethod: (name: string, options: LRUCache.FetcherOptions<string, T, unknown>) => Promise<T | undefined>,
 ) {
   const cache = new LRUCache<string, T>({
     max: 500,
@@ -14,11 +14,12 @@ export function createCachedFetch<T extends object>(
     fetchMethod: async (name, staleValue, options) => {
       try {
         logger.info(`[${name}]: fetching ${key}...`)
-        const r = await fetchMethod(name, staleValue, options)
+        const r = await fetchMethod(name, options)
         logger.info(`[${name}] fetching ${key} done!`)
         return r
       } catch (err) {
         logger.warn(`[${name}] fetching ${key} error: `, err)
+        return staleValue
       }
     },
   })

src/utils/npm.ts

@@ -27,7 +27,7 @@ export function encodePackageName(name: string): string {
 
 export const getPackageInfo = createCachedFetch<ResolvedPackument>(
   'package info',
-  async (name, staleValue, { signal }) => {
+  async (name, { signal }) => {
     const encodedName = encodePackageName(name)
 
     const pkg = await ofetch<Packument>(`${NPM_REGISTRY}/${encodedName}`, { signal })

src/utils/npmx.ts

@@ -7,10 +7,10 @@ export const NPMX_DEV_API = 'https://npmx.dev/api'
 
 export const getReplacement = createCachedFetch<ModuleReplacement>(
   'replacement',
-  (name, staleValue, { signal }) => {
+  async (name, { signal }) => {
     const encodedName = encodePackageName(name)
 
-    return ofetch<ModuleReplacement>(`${NPMX_DEV_API}/replacements/${encodedName}`, { signal })
+    return await ofetch<ModuleReplacement>(`${NPMX_DEV_API}/replacements/${encodedName}`, { signal })
       // Fallback for cache compatibility (LRUCache rejects null/undefined)
       ?? {}
   },