fix(install-browsers): stop hanging on silent playwright install#121
Open
rarmatei wants to merge 5 commits into
Open
fix(install-browsers): stop hanging on silent playwright install#121rarmatei wants to merge 5 commits into
rarmatei wants to merge 5 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 5cff3b7
☁️ Nx Cloud last updated this comment at |
rarmatei
force-pushed
the
investigate-timeouts-with-browser-step-7cf12e5d
branch
from
a340a42 to
7cb51ad
Compare
Replace async exec with execSync + stdio: 'inherit', matching the Cypress branch directly below and the install-aws-cli step. The hang was Node waiting on stdio pipes inherited by playwright's grandchild processes; with no pipes there's nothing to wait on.
…spect package manager Wrap playwright/cypress install in a retry helper modeled on install-node-modules: 3 attempts by default (NX_CLOUD_INPUT_max_retries), exponential backoff, per-attempt timeout bounded by a 10-minute total deadline so a stalled CDN download can't hang the step indefinitely. Forward execSync's .status on final failure so playwright's exit code isn't silently rewritten to 1 (restores #105). Pick the right launcher (npx / yarn / pnpm exec) based on the lockfile instead of hardcoding npx.
rarmatei
force-pushed
the
investigate-timeouts-with-browser-step-7cf12e5d
branch
from
445f802 to
c9dba4d
Compare
…, graceful json parse
….json - switch from execSync to spawn with a stderr tee: live progress streams to the parent while we still accumulate stderr for the apt-recovery regex (and no 1 MB maxBuffer ceiling) - drop the silent return on malformed package.json so a parse error surfaces via the top-level catch (exit 1) as it did before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execpipes stdio; playwright spawns helpers (npx wrapper, unzip, host validators) that inherit those pipe fds and outlive the immediate child, so the'close'event never firesthis PR:
execSyncwithstdio: 'inherit'install-aws-cli,install-mise,install-node,install-node-modules)