fix(gemini-delegate): address Copilot review findings (C1-C8)

C1: gemini_check_path_safe — use *$pattern* substring matching to
    block nested secrets (config/.env, secrets/.env.prod, foo/.git/config).
    Patterns: .env.* → .env., .git/* → .git/ for correct glob behaviour.

C2: gemini_preflight — add command -v gemini check before auth check.

C3: delegate-analyze.sh — guard content >1.5MB before --prompt arg
    (OS ARG_MAX ~2MB on Linux; headroom for prompt wrapper + env).

C4: plugin.json — fix license "Apache-2.0" → "MIT" (matches LICENSE file).

C5: escalate-review.sh — correct misleading comment; script is standalone,
    _lib.sh::gemini_escalate() is the runtime code path.

C6: README.md — Python 3 listed as required (not graceful degradation);
    clarifies JSON validation and codegen validator dependency.

C7: delegate-format.sh — fence stripping: sed -e '1{/^```/d}' -e '${/^```$/d}'
    instead of /^```/d to avoid corrupting fences inside formatted content.

C8: _lib.sh gemini_invoke_with_retry — remove trap RETURN (global bash scope
    fires on every function return); add explicit rm -f before each exit/return.

Generated by Nuno Salvação <nuno.salvacao@gmail.com> & Co-Authored with: Nexo <nexo.modeling@gmail.com>

Author: nsalvacao

plugins/gemini-delegate/.claude-plugin/plugin.json

@@ -8,6 +8,6 @@
   },
   "homepage": "https://github.com/nsalvacao/nsalvacao-claude-code-plugins",
   "repository": "https://github.com/nsalvacao/nsalvacao-claude-code-plugins",
-  "license": "Apache-2.0",
+  "license": "MIT",
   "keywords": ["gemini", "delegation", "deterministic-validation", "pipeline", "google-search", "code-generation", "ui-generation", "large-context", "token-economy", "multi-llm"]
 }

plugins/gemini-delegate/README.md

@@ -25,7 +25,7 @@ Offload text, code, research, large-file analysis, and UI generation to the Gemi
 - `gemini` CLI installed and authenticated (v0.36.0+)
 - Verify: `gemini --version`
 - Authenticate: run `gemini` interactively → Google OAuth
-- Python 3 (for validators — graceful degradation if absent)
+- Python 3 (required for JSON syntax validation and Python codegen validators)
 - `jq` (required for JSON response parsing)
 
 ## Installation

plugins/gemini-delegate/scripts/_lib.sh

@@ -29,22 +29,27 @@ gemini_preflight() {
     log_error "jq is not installed. Install it to use gemini-delegate (e.g., 'sudo apt install jq')."
     exit "${EXIT_PREFLIGHT_FAIL}"
   fi
+  if ! command -v gemini &>/dev/null; then
+    log_error "gemini CLI is not installed or not on PATH. Install it, then run: gemini (Google OAuth)"
+    exit "${EXIT_PREFLIGHT_FAIL}"
+  fi
   if [[ ! -f "$GEMINI_SETTINGS" ]]; then
     log_error "Gemini not authenticated. Run: gemini (Google OAuth interactive login)"
     exit "${EXIT_PREFLIGHT_FAIL}"
   fi
-  log_info "Auth: OK (settings.json present)"
+  log_info "Preflight: OK (jq present, gemini CLI available, settings.json found)"
 }
 
 # --- Pre-flight: path safelist ---
 # Usage: gemini_check_path_safe "path/to/file"
+# Uses substring matching (*$pattern*) to block secrets in nested paths (e.g. config/.env)
 gemini_check_path_safe() {
   local file="$1"
-  local -a denied_patterns=(".env" ".env.*" "*.pem" "*.key" "*.p12" "*.pfx" "*.secret" "*password*" "*credential*" "*_secret*" ".git" ".git/*")
+  local -a denied_patterns=(".env" ".env." "*.pem" "*.key" "*.p12" "*.pfx" "*.secret" "*password*" "*credential*" "*_secret*" ".git" ".git/")
   for pattern in "${denied_patterns[@]}"; do
     # shellcheck disable=SC2254
     case "$file" in
-      $pattern)
+      *$pattern*)
         log_error "DENIED: '$file' matches safelist pattern '$pattern'. Never delegate secrets."
         return "${EXIT_PREFLIGHT_FAIL}"
         ;;
@@ -79,9 +84,10 @@ gemini_invoke_with_retry() {
   local exit_code=0
   local raw_json=""
 
-  local _stderr_file
+  local _stderr_file _rc
   _stderr_file=$(mktemp /tmp/gemini_stderr_XXXXXX.txt)
-  trap 'rm -f "$_stderr_file"' RETURN
+  # No trap RETURN — bash traps are global and would fire on every nested function return.
+  # Explicit rm -f before every exit/return path ensures cleanup without side effects.
 
   while (( attempt < max_retries )); do
     attempt=$((attempt + 1))
@@ -97,6 +103,7 @@ gemini_invoke_with_retry() {
     # Auth error — exit immediately, no retry
     if (( exit_code == EXIT_AUTH_FAIL )); then
       log_error "Gemini auth error (exit 41). Run: gemini (Google OAuth)"
+      rm -f "$_stderr_file"
       exit "${EXIT_AUTH_FAIL}"
     fi
 
@@ -106,14 +113,17 @@ gemini_invoke_with_retry() {
         log_warn "Retrying..."
         continue
       fi
-      return "$exit_code"
+      _rc="$exit_code"
+      rm -f "$_stderr_file"
+      return "$_rc"
     fi
 
     # Check for error in JSON body (Gemini may exit 0 with error payload)
     local err_code
     err_code=$(echo "$raw_json" | jq -r '.error.code // empty' 2>/dev/null || true)
     if [[ "$err_code" == "41" ]]; then
       log_error "Gemini auth error in JSON payload. Run: gemini (Google OAuth)"
+      rm -f "$_stderr_file"
       exit "${EXIT_AUTH_FAIL}"
     fi
 
@@ -123,13 +133,16 @@ gemini_invoke_with_retry() {
       if (( attempt < max_retries )); then
         continue
       fi
+      rm -f "$_stderr_file"
       return "${EXIT_VALIDATOR_FAIL}"
     fi
 
+    rm -f "$_stderr_file"
     return 0
   done
 
   log_error "All $max_retries attempts exhausted."
+  rm -f "$_stderr_file"
   return "${EXIT_VALIDATOR_FAIL}"
 }
 

plugins/gemini-delegate/scripts/delegate-analyze.sh

@@ -53,6 +53,13 @@ fi
 
 CHAR_COUNT=$(wc -c < "$_content_file" | tr -d ' ')
 log_info "Total content size: $CHAR_COUNT characters"
+
+# Guard: OS ARG_MAX is ~2MB on Linux; leave headroom for prompt wrapper + env.
+if (( CHAR_COUNT > 1500000 )); then
+  log_error "Content too large (${CHAR_COUNT} bytes, limit 1 500 000). Split input or reduce scope."
+  exit 1
+fi
+
 CONTENT=$(cat "$_content_file")
 
 PROMPT="Analyze the following content and answer this question:

plugins/gemini-delegate/scripts/delegate-format.sh

@@ -58,8 +58,9 @@ esac
 gemini_invoke_with_retry "$GEMINI_DELEGATE_MAX_RETRIES" "$PROMPT" "$TURNS_MODEL" "plan"
 FORMATTED="$GEMINI_RESPONSE"
 
-# Strip markdown fences if Gemini included them
-FORMATTED=$(echo "$FORMATTED" | sed '/^```/d')
+# Strip markdown fences if Gemini included them (first and last line only — avoids
+# removing ``` that may appear inside formatted markdown or code blocks)
+FORMATTED=$(echo "$FORMATTED" | sed -e '1{/^```/d}' -e '${/^```$/d}')
 
 # ---- Validators ----
 case "$FORMAT_TYPE" in
@@ -71,7 +72,7 @@ case "$FORMAT_TYPE" in
 ${INPUT_TEXT}"
       gemini_invoke_with_retry "$GEMINI_DELEGATE_MAX_RETRIES" "$RETRY_PROMPT" "$TURNS_MODEL" "plan"
       FORMATTED="$GEMINI_RESPONSE"
-      FORMATTED=$(echo "$FORMATTED" | sed '/^```/d')
+      FORMATTED=$(echo "$FORMATTED" | sed -e '1{/^```/d}' -e '${/^```$/d}')
       if ! python3 -m json.tool <<< "$FORMATTED" > /dev/null 2>&1; then
         gemini_escalate "formatting-json" "output is not valid JSON after retry" '{"json_syntax":"fail"}'
       fi

plugins/gemini-delegate/scripts/escalate-review.sh

@@ -2,7 +2,7 @@
 # Emit a structured escalation payload for Claude to act on.
 # Usage: escalate-review.sh <category> <error_message> [validators_json]
 # Stdout: <gemini_escalation>JSON</gemini_escalation>
-# This script is normally called BY _lib.sh::gemini_escalate(), not directly.
+# This script is a standalone helper; _lib.sh::gemini_escalate() is the runtime path.
 set -euo pipefail
 
 CATEGORY="${1:-unknown}"