fix(waterfall-lifecycle): address Copilot review — schema fields, enums, script bugs

- init-lifecycle.sh: use 'schema' field (not '$schema'), add missing required
  fields product_type/team/sponsor/updated to generated lifecycle-state.json
- validate-schema.sh: fix schema file resolution (.json → .schema.json),
  update comments to reference 'schema'/'$schema' instead of '$id'
- validate-artefact.sh: fix schema discovery to read 'schema'/'$schema' fields
  (not '$id'), fix schema filename resolution (.json → .schema.json)
- phase-contract.schema.json: fix entry criteria status enum to YES/NO/PARTIAL/
  not_assessed; fix exit criteria status enum to not_started/in_progress/met/waived
- lifecycle-state.schema.json: add 'embedded' to product_type enum
- risk-management/SKILL.md: fix HIGH threshold ≥10 (was ≥12), fix status
  'flagged' → 'open' to match valid schema values
- walkthrough-init-phase1.md: fix gate-reviews/ → gate-reports/ (matches init)
- waterfall-lifecycle-status.md: clarify register files may not exist after init

Generated by Nuno Salvação

Co-Authored-By: Nexo <nexo.modeling@gmail.com>

Author: nsalvacao

plugins/waterfall-lifecycle/commands/waterfall-lifecycle-status.md

@@ -28,8 +28,8 @@ This command is read-only and safe to run at any time. It does not modify `lifec
 1. Reads `lifecycle-state.json` from `.waterfall-lifecycle/`.
 2. Shows the current phase number, phase name, and status (`in_progress` / `ready_for_gate` / `approved` / `blocked`).
 3. Shows all 8 gates (A-H) with their current status (`pending` / `passed` / `failed` / `waived`), mapping each gate to its associated phase.
-4. Lists all open risk register entries with impact level `medium` or higher from `.waterfall-lifecycle/registers/risk-register.md`.
-5. Lists clarifications marked as `overdue` from `.waterfall-lifecycle/registers/clarification-log.md`.
+4. Lists all open risk register entries with impact level `medium` or higher from `.waterfall-lifecycle/registers/risk-register.md` (skipped if file does not exist yet).
+5. Lists clarifications marked as `overdue` from `.waterfall-lifecycle/registers/clarification-log.md` (skipped if file does not exist yet).
 6. Shows the elapsed time since `lifecycle-state.json` was last modified.
 
 ## Examples

plugins/waterfall-lifecycle/docs/walkthrough-init-phase1.md

@@ -16,7 +16,7 @@ The `lifecycle-orchestrator` agent runs and creates the directory structure unde
 .waterfall-lifecycle/
   lifecycle-state.json         # Phase 1 active, gates A-H pending
   artefacts/phase-1/           # Phase 1 working directory
-  gate-reviews/                # Gate review reports
+  gate-reports/                # Gate review reports
 ```
 
 You are prompted to confirm the project name and product type.

plugins/waterfall-lifecycle/hooks/scripts/validate-artefact.sh

@@ -24,19 +24,19 @@ if ! python3 -c "import json; json.load(open('${FILE_PATH}'))" 2>/dev/null; then
   exit 0
 fi
 
-# Try schema validation if \$id field is present
+# Try schema validation if 'schema' or '$schema' field is present
 SCHEMA_ID=$(python3 -c "
 import json, sys
 try:
     d = json.load(open('${FILE_PATH}'))
-    print(d.get('\$id', ''))
+    print(d.get('schema', d.get('\$schema', '')))
 except Exception:
     print('')
 " 2>/dev/null || true)
 
 if [[ -n "$SCHEMA_ID" && -n "${CLAUDE_PLUGIN_ROOT:-}" ]]; then
-  SCHEMA_NAME=$(basename "$SCHEMA_ID" .json)
-  SCHEMA_FILE="${CLAUDE_PLUGIN_ROOT}/schemas/${SCHEMA_NAME}.json"
+  SCHEMA_NAME=$(basename "$SCHEMA_ID")
+  SCHEMA_FILE="${CLAUDE_PLUGIN_ROOT}/schemas/${SCHEMA_NAME}.schema.json"
   if [[ -f "$SCHEMA_FILE" ]]; then
     if ! python3 -c "
 import json, sys

plugins/waterfall-lifecycle/schemas/lifecycle-state.schema.json

@@ -21,7 +21,7 @@
     },
     "product_type": {
       "type": "string",
-      "enum": ["saas", "web", "desktop", "cli", "ai-ml", "data-product", "other"],
+      "enum": ["saas", "web", "desktop", "cli", "ai-ml", "data-product", "embedded", "other"],
       "description": "Product type used for tailoring and gate configuration"
     },
     "team": {

plugins/waterfall-lifecycle/schemas/phase-contract.schema.json

@@ -52,7 +52,7 @@
           },
           "status": {
             "type": "string",
-            "enum": ["not_started", "in_progress", "blocked", "ready_for_gate", "approved", "rejected", "waived", "closed"],
+            "enum": ["YES", "NO", "PARTIAL", "not_assessed"],
             "description": "Fulfilment status of this entry criterion"
           }
         }
@@ -76,7 +76,7 @@
           },
           "status": {
             "type": "string",
-            "enum": ["not_started", "in_progress", "blocked", "ready_for_gate", "approved", "rejected", "waived", "closed"],
+            "enum": ["not_started", "in_progress", "met", "waived"],
             "description": "Fulfilment status of this exit criterion"
           },
           "evidence_ref": {

plugins/waterfall-lifecycle/scripts/init-lifecycle.sh

@@ -65,10 +65,14 @@ mkdir -p "$WF_DIR/metrics"
 # Create lifecycle-state.json
 cat > "$WF_DIR/lifecycle-state.json" <<EOF
 {
-  "\$schema": "waterfall-lifecycle/lifecycle-state",
+  "schema": "waterfall-lifecycle/lifecycle-state",
   "version": "0.1.0",
   "project_name": "",
+  "product_type": "other",
+  "team": "",
+  "sponsor": "",
   "created": "$TODAY",
+  "updated": "$TODAY",
   "phases": {
     "1": {
       "name": "Opportunity and Feasibility",

plugins/waterfall-lifecycle/scripts/validate-schema.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # validate-schema.sh — Validate a JSON file against its waterfall-lifecycle schema.
 # Usage: ./validate-schema.sh <json-file> [schema-file]
-# If schema-file omitted, infers from $id field in json-file.
+# If schema-file omitted, infers from 'schema' or '$schema' field in json-file.
 set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
@@ -15,7 +15,7 @@ usage() {
   echo "Arguments:"
   echo "  json-file     Path to the JSON file to validate"
   echo "  schema-file   Optional: path to JSON schema file"
-  echo "                If omitted, infers from \$id field in json-file"
+  echo "                If omitted, infers from 'schema' or '\$schema' field in json-file"
   echo ""
   echo "Examples:"
   echo "  $(basename "$0") .waterfall-lifecycle/lifecycle-state.json"
@@ -65,7 +65,7 @@ if [[ -z "$SCHEMA_FILE" ]]; then
   if [[ -n "$SCHEMA_ID" ]]; then
     # Try to resolve schema relative to plugin schemas/ directory
     SCHEMA_NAME=$(basename "$SCHEMA_ID")
-    CANDIDATE="$PLUGIN_DIR/schemas/${SCHEMA_NAME}.json"
+    CANDIDATE="$PLUGIN_DIR/schemas/${SCHEMA_NAME}.schema.json"
     if [[ -f "$CANDIDATE" ]]; then
       SCHEMA_FILE="$CANDIDATE"
     else

plugins/waterfall-lifecycle/skills/risk-management/SKILL.md

@@ -60,8 +60,8 @@ Assign one of the 7 formal risk categories:
 
 Use the defined taxonomy. Ad-hoc labels are not accepted.
 
-### Step 5: Handle HIGH Risks (score ≥ 12)
-- Flag the item immediately in the register (status: `flagged`)
+### Step 5: Handle HIGH Risks (score ≥ 10)
+- Flag the item immediately in the register (status: `open`)
 - Add the risk to the phase contract risk summary section
 - Include the risk in the gate review risk report
 - Define a mitigation action and assign an owner with a deadline