Don't error on mismatches when actual value is a Datomic EntityMap#232
Merged
philomates merged 3 commits intomasterfrom Jan 27, 2026
Merged
Don't error on mismatches when actual value is a Datomic EntityMap#232philomates merged 3 commits intomasterfrom
actual value is a Datomic EntityMap#232philomates merged 3 commits intomasterfrom
Conversation
philomates
force-pushed
the
mismatch-datomic-entity-map
branch
from
c995f43 to
663f49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to match for Datomic EntityMap values (or other values that only partially implement
clojure.lang.Associative), mismatches will result in errors:This change gets around this by first converting the
actualto a map so assoc'ing mismatch info is possible.Note: this change will mean that in specific cases the data-structure returned by the library will not have the exact same type as the provided
actualvalue. The chances that this causes confusion are minimal (probably only if you interact with data coming back from the library instead of just test report output).