Commit 9376d5d
Fix timeline track selection issues from Copilot review
- Coalesce selectedTimelineTrackId to null when loading a project file
saved before this field existed, so it can't leak undefined into
state.
- Require both selectedTrackId and setSelectedTrackId before Timeline
enters controlled mode, so passing only the setter can't strand
selection at null.
- Route [i]/[x] keydown handling through a shared stack so only the
most recently mounted Timeline instance responds, preventing
double-inserts/deletes when the global and per-input panels are both
mounted.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 357dcf4 commit 9376d5d
2 files changed
Lines changed: 28 additions & 3 deletions
File tree
- apps/desktop/src/renderer/handlers
- packages/timeline/src/components/Timeline
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
26 | 50 | | |
27 | 51 | | |
28 | 52 | | |
| |||
37 | 61 | | |
38 | 62 | | |
39 | 63 | | |
40 | | - | |
| 64 | + | |
| 65 | + | |
41 | 66 | | |
42 | 67 | | |
43 | 68 | | |
| |||
82 | 107 | | |
83 | 108 | | |
84 | 109 | | |
85 | | - | |
86 | | - | |
| 110 | + | |
87 | 111 | | |
88 | 112 | | |
89 | 113 | | |
| |||
0 commit comments