Fix build ldflags and build date string

Author: Richy-Z

.github/workflows/release-test.yml

@@ -52,16 +52,15 @@ jobs:
                     VERSION="0.0.0"
                   fi
 
-                  VERSION=${{ github.ref_name }}
                   COMMIT=${{ github.sha }}
-                  DATE=$(date -u +%Y-%m-%dT%H:%M:%SZ)
+                  DATE=$(date -u +"%Y-%m-%d at %H:%M:%S")
 
                   GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }} \
                   go build \
                   -ldflags "\
-                  -X constants.Version=$VERSION \
-                  -X constants.Commit=$COMMIT \
-                  -X constants.BuildDate=$DATE \
+                  -X sklair/constants.Version=$VERSION \
+                  -X sklair/constants.Commit=$COMMIT \
+                  -X sklair/constants.BuildDate=$DATE \
                   " \
                   -o dist/sklair-${{ matrix.os }}-${{ matrix.arch }}$EXT
 

constants/version.go

@@ -1,20 +1,8 @@
 package constants
 
-var (
-	Version   = "0.1.0"   // to be replaced by ldflags during compile time in a GitHub runner
-	Commit    = "unknown" // likewise
-	BuildDate = "unknown" // likewise, ISO-8601 UTC
+// these are replaced by ldflags during compile time on release
+const (
+	Version   = "0.0.0" // `MAJOR.MINOR.PATCH`, semantic versioning
+	Commit    = "unknown commit"
+	BuildDate = "unknown date" // `YYYY-MM-DD at HH:MM:SS`
 )
-
-/*
-VERSION=v0.0.0
-COMMIT=$(git rev-parse --short HEAD)
-DATE=$(date -u +%Y-%m-%dT%H:%M:%SZ)
-
-go build \
-  -ldflags "\
-    -X sklair/constants.Version=$VERSION \
-    -X sklair/constants.Commit=$COMMIT \
-    -X sklair/constants.BuildDate=$DATE \
-  "
-*/