Update nvidia-device-plugin-app

Author: nwthomas

docs/SETUP.md

@@ -1097,4 +1097,58 @@ As an aside, you can also add an alias on the node in question to shut it down w
 
 ```bash
 alias shutdown="systemctl poweroff"
-```
+```
+
+Once you're done with all of the above, you'll need to go into your BIOS and ensure the following settings are setup:
+
+1. ErP is disabled
+2. Wake on PCIe is enabled
+
+#### GPU Node Setup
+
+Follow Nvidia's setup steps here for `nvidia-container-toolkit`:
+
+https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html
+
+
+
+TODO
+
+Test with `containerd` that the Nvidia GPU is available:
+
+```bash
+sudo ctr image pull docker.io/nvidia/cuda:12.3.2-base-ubuntu22.04
+
+sudo ctr run --rm --gpus 0 -t docker.io/nvidia/cuda:12.3.2-base-ubuntu22.04 cuda-12.3.2-base-ubuntu22.04 nvidia-smi
+```
+
+If there are any issues with `containerd`, make sure that the following is set up for the `/etc/containerd/config.d/99-nvidia.toml` file:
+
+```toml
+
+```
+
+#### Helpful Commands
+
+````bash
+version = 2
+
+[plugins]
+
+  [plugins."io.containerd.grpc.v1.cri"]
+
+    [plugins."io.containerd.grpc.v1.cri".containerd]
+
+      [plugins."io.containerd.grpc.v1.cri".containerd.runtimes]
+
+        [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
+          runtime_type = "io.containerd.runc.v2"
+
+        [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia]
+          privileged_without_host_devices = false
+          runtime_root = ""
+          runtime_type = "io.containerd.runc.v2"
+
+          [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.nvidia.options]
+            BinaryName = "/usr/bin/nvidia-container-runtime"
+````

helm/nvidia-device-plugin/values.yaml

@@ -4,7 +4,6 @@ image:
   pullPolicy: IfNotPresent
 
 nodeSelector:
-  # Target GPU nodes specifically
   kubernetes.io/arch: amd64
   gpu: "true"
 
@@ -16,29 +15,25 @@ resources:
     memory: 64Mi
     cpu: 50m
 
-# Security context for the device plugin
 securityContext:
   privileged: true
 
-# Tolerations for GPU nodes
 tolerations:
   - key: gpu
     operator: Equal
     value: "true"
     effect: NoExecute
 
-# Environment variables for nvidia-device-plugin
 env:
   - name: DEVICE_LIST_STRATEGY
-    value: "envvar"  # Use envvar for device list strategy
+    value: "envvar"
   - name: DEVICE_ID_STRATEGY
     value: "uuid"
   - name: NVIDIA_VISIBLE_DEVICES
     value: "all"
   - name: NVIDIA_DRIVER_CAPABILITIES
     value: "compute,utility"
 
-# Mount the NVIDIA libraries and device files
 volumeMounts:
   - name: device-plugin
     mountPath: /var/lib/kubelet/device-plugins