fix(gates): allow routine_execution self-close from todo → done (DLD-3231)

Two platform gates were blocking routine monitors from closing:
1. invalid_agent_transition: agents could not transition todo → done
2. done_requires_qa_pass: fires on done for code issues not in in_review

Fixes:
- assertAgentTransition: allow todo → done when originKind === 'routine_execution'
- assertQAGate: return null early for originKind === 'routine_execution'

Added transition-gate tests for routine execution self-close behavior.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Author: TzuhekBareket

server/src/__tests__/transition-gate.test.ts

@@ -319,4 +319,51 @@ describe("transition gate", () => {
     // Delivery gate should NOT have been reached
     expect(mockWorkProductService.listForIssue).not.toHaveBeenCalled();
   });
+
+  describe("routine execution self-close (DLD-3231)", () => {
+    it("agent: routine_execution todo → done allowed", async () => {
+      const issue = makeIssue({
+        status: "todo",
+        originKind: "routine_execution",
+        originId: "routine-1",
+        originRunId: "run-1",
+        executionWorkspaceId: null,
+      });
+      mockIssueService.getById.mockResolvedValue(issue);
+      mockIssueService.update.mockResolvedValue({ ...issue, status: "done" });
+
+      const res = await request(createAgentApp())
+        .patch(`/api/issues/${issue.id}`)
+        .send({ status: "done", comment: "Routine execution complete" });
+
+      expect(res.status).toBe(200);
+      // QA gate should NOT have fired (no hasReachedStatus call)
+      expect(mockIssueService.hasReachedStatus).not.toHaveBeenCalled();
+    });
+
+    it("agent: regular todo → done still blocked", async () => {
+      const issue = makeIssue({ status: "todo" });
+      mockIssueService.getById.mockResolvedValue(issue);
+
+      const res = await request(createAgentApp())
+        .patch(`/api/issues/${issue.id}`)
+        .send({ status: "done" });
+
+      expect(res.status).toBe(422);
+      expect(res.body.gate).toBe("invalid_agent_transition");
+    });
+
+    it("agent: routine_execution todo → cancelled requires comment (transition allowed)", async () => {
+      const issue = makeIssue({ status: "todo", originKind: "routine_execution" });
+      mockIssueService.getById.mockResolvedValue(issue);
+
+      // todo → cancelled is a valid transition; it only fails because comment is missing
+      const res = await request(createAgentApp())
+        .patch(`/api/issues/${issue.id}`)
+        .send({ status: "cancelled" });
+
+      expect(res.status).toBe(422);
+      expect(res.body.gate).toBe("comment_required");
+    });
+  });
 });

server/src/routes/issues.ts

@@ -240,10 +240,20 @@ export function issueRoutes(
     req: Request,
     fromStatus: string,
     toStatus: string,
+    issue?: { originKind?: string | null },
   ): { gate: string; reason: string } | null {
     if (req.actor.type !== "agent") return null;
     if (fromStatus === toStatus) return null;
 
+    // Allow routine executions to self-close without going through in_review
+    if (
+      fromStatus === "todo" &&
+      toStatus === "done" &&
+      issue?.originKind === "routine_execution"
+    ) {
+      return null;
+    }
+
     const allowed = AGENT_ALLOWED_TRANSITIONS[fromStatus];
     if (allowed && !allowed.has(toStatus)) {
       return {
@@ -316,12 +326,14 @@ export function issueRoutes(
 
   async function assertQAGate(
     req: Request,
-    issue: { id: string; executionWorkspaceId: string | null; assigneeAgentId: string | null },
+    issue: { id: string; executionWorkspaceId: string | null; assigneeAgentId: string | null; originKind?: string | null },
     targetStatus: string,
     comments: Array<{ body: string; authorAgentId: string | null; authorUserId: string | null; createdAt: Date | string }>,
   ): Promise<{ gate: string; reason: string } | null> {
     if (req.actor.type !== "agent") return null;
     if (targetStatus !== "done") return null;
+    // Routine executions self-close without QA review
+    if (issue.originKind === "routine_execution") return null;
 
     // For code issues, verify the issue has been through in_review at some point.
     // QA: PASS posted on issues that never reached in_review indicates the review
@@ -1814,7 +1826,7 @@ export function issueRoutes(
     // Status transition gates (agent-only — board always bypasses)
     if (req.body.status && req.body.status !== existing.status) {
       // Transition graph: agents follow forward-only workflow
-      const transitionResult = assertAgentTransition(req, existing.status, req.body.status);
+      const transitionResult = assertAgentTransition(req, existing.status, req.body.status, existing);
       if (transitionResult) {
         const actor = getActorInfo(req);
         await logActivity(db, {