|
1 | 1 | { |
2 | 2 | "magic": "E!vIA5L86J2I", |
3 | | - "timestamp": "2026-06-25T01:11:16.309518+00:00", |
| 3 | + "timestamp": "2026-07-02T01:11:55.348857+00:00", |
4 | 4 | "repo": "oauth-wg/oauth-sd-jwt-vc", |
5 | 5 | "labels": [ |
6 | 6 | { |
|
10570 | 10570 | "updatedAt": "2026-06-24T19:51:03Z" |
10571 | 10571 | } |
10572 | 10572 | ] |
| 10573 | + }, |
| 10574 | + { |
| 10575 | + "number": 417, |
| 10576 | + "id": "I_kwDOJbVClc8AAAABHMUjsw", |
| 10577 | + "title": "SD-JWT is not only a superset of JWT", |
| 10578 | + "url": "https://github.com/oauth-wg/oauth-sd-jwt-vc/issues/417", |
| 10579 | + "state": "OPEN", |
| 10580 | + "author": "awoie", |
| 10581 | + "authorAssociation": "COLLABORATOR", |
| 10582 | + "assignees": [], |
| 10583 | + "labels": [], |
| 10584 | + "body": "This is already implied by the specification, we should need to make clear that \"SD-JWT builds on JWT/JWS\".", |
| 10585 | + "createdAt": "2026-06-30T14:26:05Z", |
| 10586 | + "updatedAt": "2026-06-30T18:38:22Z", |
| 10587 | + "closedAt": null, |
| 10588 | + "comments": [ |
| 10589 | + { |
| 10590 | + "author": "adeinega", |
| 10591 | + "authorAssociation": "CONTRIBUTOR", |
| 10592 | + "body": "@awoie, so that a Holder and a Verifier MUST process all extensions specified in the crit (critical) header parameter, right?\n\nhttps://datatracker.ietf.org/doc/html/rfc7515#section-4.1.11", |
| 10593 | + "createdAt": "2026-06-30T14:50:16Z", |
| 10594 | + "updatedAt": "2026-06-30T14:50:32Z" |
| 10595 | + }, |
| 10596 | + { |
| 10597 | + "author": "bc-pi", |
| 10598 | + "authorAssociation": "COLLABORATOR", |
| 10599 | + "body": "> [@awoie](https://github.com/awoie), so that a Holder and a Verifier MUST process all extensions specified in the crit (critical) header parameter, right?\n> \n> https://datatracker.ietf.org/doc/html/rfc7515#section-4.1.11\n\nThat's the case regardless of this issue or anything done for it or not. ", |
| 10600 | + "createdAt": "2026-06-30T15:30:26Z", |
| 10601 | + "updatedAt": "2026-06-30T15:30:26Z" |
| 10602 | + }, |
| 10603 | + { |
| 10604 | + "author": "adeinega", |
| 10605 | + "authorAssociation": "CONTRIBUTOR", |
| 10606 | + "body": "@bc-pi,\n\n> That's the case regardless of this issue or anything done for it or not.\n\nNow, if I may, I have one follow-up question. Should the Type Metadata documents announce extensions (which MUST be processed) in the crit claim as well?\n\nAs of now, https://github.com/oauth-wg/oauth-sd-jwt-vc/pull/416 includes this text regarding properties in the Type Metadata documents\n\n> Properties that are not understood are ignored as defined in (#type-metadata-format).", |
| 10607 | + "createdAt": "2026-06-30T18:10:04Z", |
| 10608 | + "updatedAt": "2026-06-30T18:10:04Z" |
| 10609 | + }, |
| 10610 | + { |
| 10611 | + "author": "bc-pi", |
| 10612 | + "authorAssociation": "COLLABORATOR", |
| 10613 | + "body": "> [@bc-pi](https://github.com/bc-pi),\n> \n> > That's the case regardless of this issue or anything done for it or not.\n> \n> Now, if I may, I have one follow-up question. Should the Type Metadata documents announce extensions (which MUST be processed) in the crit claim as well?\n\nFrom my perspective, no, crit is a header not a claim. But Type Metadata documents don't have headers or claims. \n\n", |
| 10614 | + "createdAt": "2026-06-30T18:22:51Z", |
| 10615 | + "updatedAt": "2026-06-30T18:22:51Z" |
| 10616 | + }, |
| 10617 | + { |
| 10618 | + "author": "adeinega", |
| 10619 | + "authorAssociation": "CONTRIBUTOR", |
| 10620 | + "body": "Of course, crit is a header, but still... should Type Metadata documents announce these extensions through their properties?\n\nIt could be one of those weird / edge use cases, but technically, an Issuer can issue two Credentials \"linked\" to the same Type Metadata documents, but with one difference - Credential_1 doesn't include a crit header, and Credential_2 does... implying that a Holder and Verifier MUST process some extensions say \"extensionA\" and \"extensionB\".", |
| 10621 | + "createdAt": "2026-06-30T18:38:22Z", |
| 10622 | + "updatedAt": "2026-06-30T18:38:22Z" |
| 10623 | + } |
| 10624 | + ] |
10573 | 10625 | } |
10574 | 10626 | ], |
10575 | 10627 | "pulls": [ |
@@ -33074,27 +33126,35 @@ |
33074 | 33126 | { |
33075 | 33127 | "number": 416, |
33076 | 33128 | "id": "PR_kwDOJbVClc7l0JJy", |
33077 | | - "title": "Fixes #408, #409, #410, #411, #412, #413", |
| 33129 | + "title": "Fixes #408, #409, #410, #411, #412, #413, #417", |
33078 | 33130 | "url": "https://github.com/oauth-wg/oauth-sd-jwt-vc/pull/416", |
33079 | 33131 | "state": "OPEN", |
33080 | 33132 | "author": "awoie", |
33081 | 33133 | "authorAssociation": "COLLABORATOR", |
33082 | 33134 | "assignees": [], |
33083 | 33135 | "labels": [], |
33084 | | - "body": "Fixes #408, #409, #410, #411, #412, #413\r\n", |
| 33136 | + "body": "Fixes #408, #409, #410, #411, #412, #413, #417\r\n", |
33085 | 33137 | "createdAt": "2026-06-12T15:15:15Z", |
33086 | | - "updatedAt": "2026-06-24T19:46:36Z", |
| 33138 | + "updatedAt": "2026-06-30T20:14:24Z", |
33087 | 33139 | "baseRepository": "oauth-wg/oauth-sd-jwt-vc", |
33088 | 33140 | "baseRefName": "main", |
33089 | 33141 | "baseRefOid": "eb1554757edb6bbd6ba3f9a89853e4442faff9da", |
33090 | 33142 | "headRepository": "oauth-wg/oauth-sd-jwt-vc", |
33091 | 33143 | "headRefName": "awoie/fix-various-issues", |
33092 | | - "headRefOid": "fb7a0c946e4b6fef2c2fce7d18cf04cce4cf7f1d", |
| 33144 | + "headRefOid": "abac43a87b1857b326ae9d1a80e89506cacaf878", |
33093 | 33145 | "closedAt": null, |
33094 | 33146 | "mergedAt": null, |
33095 | 33147 | "mergedBy": null, |
33096 | 33148 | "mergeCommit": null, |
33097 | | - "comments": [], |
| 33149 | + "comments": [ |
| 33150 | + { |
| 33151 | + "author": "danielfett", |
| 33152 | + "authorAssociation": "MEMBER", |
| 33153 | + "body": "Thank you!", |
| 33154 | + "createdAt": "2026-06-30T14:13:04Z", |
| 33155 | + "updatedAt": "2026-06-30T14:13:04Z" |
| 33156 | + } |
| 33157 | + ], |
33098 | 33158 | "reviews": [ |
33099 | 33159 | { |
33100 | 33160 | "id": "PRR_kwDOJbVClc8AAAABEB40BA", |
|
33108 | 33168 | "createdAt": "2026-06-24T19:46:36Z", |
33109 | 33169 | "updatedAt": "2026-06-24T19:46:36Z", |
33110 | 33170 | "comments": [] |
| 33171 | + }, |
| 33172 | + { |
| 33173 | + "id": "PRR_kwDOJbVClc8AAAABEj-I1w", |
| 33174 | + "commit": { |
| 33175 | + "abbreviatedOid": "fb7a0c9" |
| 33176 | + }, |
| 33177 | + "author": "danielfett", |
| 33178 | + "authorAssociation": "MEMBER", |
| 33179 | + "state": "APPROVED", |
| 33180 | + "body": "", |
| 33181 | + "createdAt": "2026-06-30T14:12:52Z", |
| 33182 | + "updatedAt": "2026-06-30T14:12:52Z", |
| 33183 | + "comments": [] |
| 33184 | + }, |
| 33185 | + { |
| 33186 | + "id": "PRR_kwDOJbVClc8AAAABEl7JWA", |
| 33187 | + "commit": { |
| 33188 | + "abbreviatedOid": "abac43a" |
| 33189 | + }, |
| 33190 | + "author": "adeinega", |
| 33191 | + "authorAssociation": "CONTRIBUTOR", |
| 33192 | + "state": "COMMENTED", |
| 33193 | + "body": "", |
| 33194 | + "createdAt": "2026-06-30T18:44:27Z", |
| 33195 | + "updatedAt": "2026-06-30T18:44:27Z", |
| 33196 | + "comments": [ |
| 33197 | + { |
| 33198 | + "originalPosition": 5, |
| 33199 | + "body": "`\"crit\":[\"b64\"]` and a detached payload is not supported, right?\n\nhttps://datatracker.ietf.org/doc/html/rfc7797", |
| 33200 | + "createdAt": "2026-06-30T18:44:27Z", |
| 33201 | + "updatedAt": "2026-06-30T18:44:27Z" |
| 33202 | + } |
| 33203 | + ] |
| 33204 | + }, |
| 33205 | + { |
| 33206 | + "id": "PRR_kwDOJbVClc8AAAABEmgesw", |
| 33207 | + "commit": { |
| 33208 | + "abbreviatedOid": "abac43a" |
| 33209 | + }, |
| 33210 | + "author": "adeinega", |
| 33211 | + "authorAssociation": "CONTRIBUTOR", |
| 33212 | + "state": "COMMENTED", |
| 33213 | + "body": "", |
| 33214 | + "createdAt": "2026-06-30T20:14:24Z", |
| 33215 | + "updatedAt": "2026-06-30T20:14:24Z", |
| 33216 | + "comments": [ |
| 33217 | + { |
| 33218 | + "originalPosition": 50, |
| 33219 | + "body": "```suggestion\nEcosystems can establish rules for the vct value to determine whether Type Metadata should be processed and which retrieval methods consumers must support.\n```", |
| 33220 | + "createdAt": "2026-06-30T20:14:24Z", |
| 33221 | + "updatedAt": "2026-06-30T20:14:24Z" |
| 33222 | + } |
| 33223 | + ] |
33111 | 33224 | } |
33112 | 33225 | ] |
33113 | 33226 | } |
|
0 commit comments