refactor(http): replace status code integers with enum values

oboard · oboard · commit 56581912a791 · 2025-11-25T19:00:20.000+08:00
- Replace raw status code integers with StatusCode enum for better type safety
- Update HttpResponse to use StatusCode instead of StatusCoder trait
- Add Custom variant to StatusCode enum for custom status codes
- Improve JSON handling in responder example with BodyReader implementation
diff --git a/moon.mod.json b/moon.mod.json
@@ -1,6 +1,6 @@
 {
   "name": "oboard/mocket",
-  "version": "0.5.8",
+  "version": "0.6.0",
   "deps": {
     "illusory0x0/native": "0.2.1",
     "moonbitlang/x": "0.4.34",
diff --git a/src/examples/responder/main.mbt b/src/examples/responder/main.mbt
@@ -1,8 +1,16 @@
+///|
+using @mocket {type HttpResponse}
+
 ///|
 struct Person {
   name : String
   age : Int
-} derive(ToJson)
+} derive(ToJson, FromJson)
+
+///|
+impl @mocket.BodyReader for Person with from_request(req) -> Person raise {
+  @json.from_json(req.body())
+}
 
 ///|
 fn main {
@@ -13,13 +21,29 @@ fn main {
   ..get("/", _event => "⚡️ Tadaa!")
 
   // Object Response
-  ..get("/", _event => { name: "oboard", age: 21 }.to_json())
+  ..get("/json", _event => { name: "oboard", age: 21 }.to_json())
+
+  // JSON Request
+  // curl --location 'localhost:4000/json' \
+  // --header 'Content-Type: application/json' \
+  // --data '{
+  //     "name": "oboard",
+  //     "age": 21
+  // }'
+  ..post("/json", event => try {
+    let person : Person = event.req.body()
+    HttpResponse::new(OK).body(
+      "Hello, \{person.name}. You are \{person.age} years old.",
+    )
+  } catch {
+    _ => HttpResponse::new(BadRequest).body("Invalid JSON")
+  })
 
   // Echo Server
   ..post("/echo", e => e.req)
 
   // 404 Page
-  ..get("/404", _ => @mocket.HttpResponse::new(@mocket.NotFound).body(
+  ..get("/404", _ => HttpResponse::new(NotFound).body(
     @mocket.html(
       (
         #|<html>
diff --git a/src/not_found.mbt b/src/not_found.mbt
@@ -1,4 +1,4 @@
 ///|
 pub async fn handle_not_found(_ : MocketEvent) -> &Responder noraise {
-  HttpResponse::new(404).body("Not Found")
+  HttpResponse::new(NotFound).body("Not Found")
 }
diff --git a/src/request.mbt b/src/request.mbt
@@ -8,7 +8,7 @@ pub(all) struct HttpRequest {
 
 ///|
 pub(open) trait BodyReader {
-  from_request(HttpRequest) -> Self raise
+  from_request(req: HttpRequest) -> Self raise
 }
 
 ///|
diff --git a/src/response.mbt b/src/response.mbt
@@ -1,14 +1,14 @@
 ///|
 pub(all) struct HttpResponse {
-  mut status_code : &StatusCoder
+  mut status_code : StatusCode
   headers : Map[StringView, StringView]
   cookies : Map[String, CookieItem]
   mut raw_body : Bytes
 }
 
 ///|
 pub fn HttpResponse::new(
-  status_code : &StatusCoder,
+  status_code : StatusCode,
   headers? : Map[StringView, StringView],
   cookies? : Map[String, CookieItem],
   raw_body? : Bytes,
@@ -33,8 +33,8 @@ pub fn HttpResponse::body(
 }
 
 ///|
-pub fn HttpResponse::json(self : HttpResponse, body : Json) -> HttpResponse {
-  self.body(body)
+pub fn HttpResponse::json(self : HttpResponse, obj : &ToJson) -> HttpResponse {
+  self.body(obj.to_json())
 }
 
 ///|
diff --git a/src/static.mbt b/src/static.mbt
@@ -53,7 +53,7 @@ pub fn Mocket::static_assets(
         return next()
       }
       event.res.headers.set("Allow", "GET, HEAD")
-      return HttpResponse::new(405)
+      return HttpResponse::new(MethodNotAllowed)
     }
     let original_id = event.req.url[path.length():].to_string() catch {
       _ => return next()
diff --git a/src/status_code.mbt b/src/status_code.mbt
@@ -1,13 +1,3 @@
-///|
-pub trait StatusCoder {
-  to_int(self : Self) -> Int
-}
-
-///|
-pub impl StatusCoder for Int with to_int(self) -> Int {
-  self
-}
-
 ///|
 /// HTTP status codes as registered with IANA.
 /// See: https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
@@ -136,10 +126,15 @@ pub(all) enum StatusCode {
   NotExtended
   /// RFC 6585, 6
   NetworkAuthenticationRequired
+  Custom(Int)
 } derive(Show, ToJson)
 
+pub fn StatusCode::from_int(i : Int) -> StatusCode {
+  Custom(i)
+}
+
 ///|
-pub impl StatusCoder for StatusCode with to_int(self) -> Int {
+pub fn StatusCode::to_int(self: StatusCode) -> Int {
   match self {
     Continue => 100
     SwitchingProtocols => 101
@@ -203,6 +198,7 @@ pub impl StatusCoder for StatusCode with to_int(self) -> Int {
     LoopDetected => 508
     NotExtended => 510
     NetworkAuthenticationRequired => 511
+    Custom(i) => i
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "oboard/mocket",`
`3`		`- "version": "0.5.8",`
	`3`	`+ "version": "0.6.0",`
`4`	`4`	`"deps": {`
`5`	`5`	`"illusory0x0/native": "0.2.1",`
`6`	`6`	`"moonbitlang/x": "0.4.34",`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`///\|`
`2`	`2`	`pub async fn handle_not_found(_ : MocketEvent) -> &Responder noraise {`
`3`		`- HttpResponse::new(404).body("Not Found")`
	`3`	`+ HttpResponse::new(NotFound).body("Not Found")`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ pub(all) struct HttpRequest {`
`8`	`8`
`9`	`9`	`///\|`
`10`	`10`	`pub(open) trait BodyReader {`
`11`		`- from_request(HttpRequest) -> Self raise`
	`11`	`+ from_request(req: HttpRequest) -> Self raise`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`///\|`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ pub fn Mocket::static_assets(`
`53`	`53`	`return next()`
`54`	`54`	`}`
`55`	`55`	`event.res.headers.set("Allow", "GET, HEAD")`
`56`		`- return HttpResponse::new(405)`
	`56`	`+ return HttpResponse::new(MethodNotAllowed)`
`57`	`57`	`}`
`58`	`58`	`let original_id = event.req.url[path.length():].to_string() catch {`
`59`	`59`	`_ => return next()`