Get rid of setup_form in Ot_popup

[sagotch]

I think it should be moved to another module (probably Ot_form) since every popup is not a form.

You ship more code than necessary if you are not using this feature, and once again, this module is called Ot_popup and not Ot_popup_containing_form.

[dannywillems]

I'm not against a module called Ot_form but I think popup containing forms must stay in Ot_popup.

[sagotch]

But why?

[dannywillems]

Because it's a popup. I agree it's a popup containing a form but first it is a popup. Or maybe use Ot_form_popup.

[sagotch]

The point of a popup is to... pop up.
Also, looping through a form inputs and having first field auto focused could be useful for every page or part of a page, not for popup only.

I think there is no need for having a popup specialization for forms. Just put an Ot_form in you Ot_popup and everything will be fine.