[BUG]: Preparsed payloads are not handled correctly, here Vercel

[Uzlopak]

What happened?

probot/probot#1955 (comment)

The issue arises from the fact, that vercel preparses the body. So verify can not verify the body, as it is not a string.

You can get it to work for now, by setting the NODEJS_HELPERS environment variable to 0 in vercel.

Versions

current

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

It could be nice to document this, other platforms probably have similar issues

[gr2m]

follow up to probot/probot#1973 (comment). I would throw a helpful error if anything but a string is passed to the verify method. We should probably do that in https://github.com/octokit/webhooks-methods.js. It seems right now both verify and sign silently accept objects although the types define string for the payload

[wolfy1339]

An error has been added to @octokit/webhooks-methods whenever object payloads are passed.
Is there anything else actionable in this issue?