Merge pull request #12 from alichherawalla/feat/ci

Feat/ci

Author: alichherawalla

.eslintrc.js

@@ -1,4 +1,14 @@
 module.exports = {
   root: true,
   extends: '@react-native',
+  rules: {
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_',
+      },
+    ],
+  },
 };

.github/workflows/ci.yml

@@ -0,0 +1,64 @@
+name: CI
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Lint
+        run: npm run lint
+
+  typecheck:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Type check
+        run: npx tsc --noEmit
+
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Test
+        run: npm test

App.tsx

@@ -10,7 +10,7 @@ import { GestureHandlerRootView } from 'react-native-gesture-handler';
 import { SafeAreaProvider } from 'react-native-safe-area-context';
 import { NavigationContainer } from '@react-navigation/native';
 import { AppNavigator } from './src/navigation';
-import { useTheme, getTheme } from './src/theme';
+import { useTheme } from './src/theme';
 import { hardwareService, modelManager, authService } from './src/services';
 import { useAppStore, useAuthStore } from './src/stores';
 import { LockScreen } from './src/screens';
@@ -51,6 +51,7 @@ function App() {
 
   useEffect(() => {
     initializeApp();
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   const initializeApp = async () => {

__tests__/contracts/coreMLDiffusion.contract.test.ts

@@ -6,7 +6,7 @@
  * TypeScript bridge (localDreamGenerator.ts) works on both platforms.
  */
 
-import { NativeModules, NativeEventEmitter } from 'react-native';
+export {};
 
 // The CoreMLDiffusionModule must expose the same methods as LocalDreamModule
 interface CoreMLDiffusionModuleInterface {

__tests__/contracts/iosDownloadManager.contract.test.ts

@@ -8,7 +8,6 @@
  * so that backgroundDownloadService.ts works on both platforms unchanged.
  */
 
-import { NativeModules, NativeEventEmitter } from 'react-native';
 
 // The iOS module must match this interface (same as Android)
 interface DownloadManagerModuleInterface {

__tests__/contracts/llamaContext.contract.test.ts

@@ -29,8 +29,8 @@ describe('llama.rn Contract', () => {
       use_mmap: true,
       vocab_only: false,
       flash_attn: true,
-      cache_type_k: 'f16',
-      cache_type_v: 'f16',
+      cache_type_k: 'f16' as const,
+      cache_type_v: 'f16' as const,
       n_ctx: 4096,
       n_gpu_layers: 99,
     };
@@ -62,7 +62,7 @@ describe('llama.rn Contract', () => {
         gpu: true,
         reasonNoGPU: '',
         devices: ['Apple M1'],
-        model: { metadata: { 'general.name': 'test-model' } },
+        model: { metadata: { 'general.name': 'test-model' } } as any,
         androidLib: undefined,
         systemInfo: 'Apple M1 Pro',
         completion: jest.fn(),

__tests__/contracts/localDream.contract.test.ts

@@ -5,7 +5,7 @@
  * matches our TypeScript expectations for image generation.
  */
 
-import { NativeModules, NativeEventEmitter } from 'react-native';
+export {};
 
 // Define the expected interface
 interface LocalDreamModuleInterface {
@@ -214,7 +214,7 @@ describe('LocalDream Contract', () => {
       };
       (mockLocalDreamModule.generateImage as jest.Mock).mockResolvedValue(mockResult);
 
-      const result = await mockLocalDreamModule.generateImage(validGenerateParams);
+      await mockLocalDreamModule.generateImage(validGenerateParams);
 
       expect(mockLocalDreamModule.generateImage).toHaveBeenCalledWith(
         expect.objectContaining({

__tests__/integration/generation/generationFlow.test.ts

@@ -9,7 +9,6 @@
  * not just that they work in isolation.
  */
 
-import { useChatStore } from '../../../src/stores/chatStore';
 import { useAppStore } from '../../../src/stores/appStore';
 import { generationService } from '../../../src/services/generationService';
 import { llmService } from '../../../src/services/llm';
@@ -70,8 +69,8 @@ describe('Generation Flow Integration', () => {
       const conversationId = setupWithConversation({ modelId });
 
       const tokens = ['Hello', ' ', 'world', '!'];
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -102,7 +101,7 @@ describe('Generation Flow Integration', () => {
       expect(generationService.getState().streamingContent).toBe('Hello world!');
 
       // Complete generation
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
 
       // Verify state reset
@@ -114,8 +113,8 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -141,16 +140,16 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
       expect(onFirstToken).toHaveBeenCalledTimes(1);
 
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
     });
 
     it('should transition isThinking from true to false on first token', async () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -173,7 +172,7 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
       expect(generationService.getState().isThinking).toBe(false);
 
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
     });
   });
@@ -183,7 +182,7 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let completeCallback: (() => void) | null = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, _onStream, onComplete, _onError, _onThinking) => {
@@ -202,16 +201,16 @@ describe('Generation Flow Integration', () => {
       expect(chatState.streamingForConversationId).toBe(conversationId);
       expect(chatState.isThinking).toBe(true);
 
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
     });
 
     it('should append tokens to chatStore streamingMessage', async () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -235,7 +234,7 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
       expect(getChatState().streamingMessage).toBe('Hello world');
 
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
     });
 
@@ -250,8 +249,8 @@ describe('Generation Flow Integration', () => {
         activeModelId: modelId,
       });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -271,7 +270,7 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
 
       // Complete generation
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
 
       // Verify message was finalized
@@ -312,8 +311,8 @@ describe('Generation Flow Integration', () => {
         lastTokenCount: 75,
       });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -329,7 +328,7 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
       streamCallback?.('Response');
       await flushPromises();
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
 
       const chatState = getChatState();
@@ -347,11 +346,11 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let errorCallback: ((error: Error) => void) | null = null;
+      let _errorCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, _onStream, _onComplete, onError, _onThinking) => {
-          errorCallback = onError!;
+          _errorCallback = onError!;
           throw new Error('Generation failed');
         }
       );
@@ -429,7 +428,7 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let streamCallback: ((token: string) => void) | null = null;
+      let streamCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, _onComplete, _onError, _onThinking) => {
@@ -478,7 +477,7 @@ describe('Generation Flow Integration', () => {
         activeModelId: modelId,
       });
 
-      let streamCallback: ((token: string) => void) | null = null;
+      let streamCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, _onComplete, _onError, _onThinking) => {
@@ -536,8 +535,8 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let streamCallback: ((token: string) => void) | null = null;
-      let completeCallback: (() => void) | null = null;
+      let streamCallback: any = null;
+      let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
         async (_messages, onStream, onComplete, _onError, _onThinking) => {
@@ -557,7 +556,7 @@ describe('Generation Flow Integration', () => {
       await flushPromises();
       streamCallback?.('Token');
       await flushPromises();
-      completeCallback?.();
+      completeCallback?.('');
       await generatePromise;
 
       unsubscribe();
@@ -566,15 +565,15 @@ describe('Generation Flow Integration', () => {
       expect(values.length).toBeGreaterThan(1);
 
       // First update after initial state should show generating
-      const generatingState = values.find(v => v.isGenerating);
+      const generatingState = values.find((v: any) => v.isGenerating);
       expect(generatingState).toBeDefined();
 
       // Should have a state with content
-      const contentState = values.find(v => v.streamingContent === 'Token');
+      const contentState = values.find((v: any) => v.streamingContent === 'Token');
       expect(contentState).toBeDefined();
 
       // Last state should be idle
-      const lastState = values[values.length - 1];
+      const lastState: any = values[values.length - 1];
       expect(lastState.isGenerating).toBe(false);
     });
   });