fix(sqlstore): create tables registered after engine initialization

When a table was registered via create_table() after _ensure_engine()
had already called metadata.create_all(), the table was added to
SQLAlchemy's MetaData but never physically created in the database.
This caused "no such table" errors when providers initialized in a
sequence where one provider triggered the engine before another
registered its tables (e.g. vector_io before responses).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Sébastien Han <seb@redhat.com>

Author: leseb

src/ogx/core/storage/sqlstore/sqlalchemy_sqlstore.py

@@ -185,7 +185,13 @@ async def create_table(
         # Register table in metadata - actual creation happens in _ensure_engine()
         if table not in self.metadata.tables:
             Table(table, self.metadata, *sqlalchemy_columns)
-        # If table already exists in metadata, we're done (no need to recreate)
+
+            # If engine is already running, create the new table immediately.
+            # _ensure_engine() only calls create_all once, so tables registered
+            # after that first call would never be physically created.
+            if self._engine is not None:
+                async with self._engine.begin() as conn:
+                    await conn.run_sync(self.metadata.create_all, checkfirst=True)
 
     async def insert(self, table: str, data: Mapping[str, Any] | Sequence[Mapping[str, Any]]) -> None:
         await self._ensure_engine()  # Lazy init in current event loop

tests/unit/utils/sqlstore/test_sqlstore.py

@@ -602,3 +602,34 @@ async def test_pool_recycle_is_configurable():
         pool_recycle=300,
     )
     assert cfg.pool_recycle == 300
+
+
+async def test_late_table_creation_after_engine_init():
+    """Tables registered after the engine has started are still physically created.
+
+    When one provider triggers _ensure_engine (via a data operation) before another
+    provider registers its tables, the late tables must still be created in the
+    database. Regression test for the 'no such table: responses' CI failure.
+    """
+    with TemporaryDirectory() as tmp_dir:
+        db_path = tmp_dir + "/late_table.db"
+        config = SqliteSqlStoreConfig(db_path=db_path)
+        store = SqlAlchemySqlStoreImpl(config)
+
+        await store.create_table(
+            "early_table",
+            {"id": ColumnDefinition(type=ColumnType.STRING, primary_key=True), "data": ColumnType.STRING},
+        )
+        await store.insert("early_table", {"id": "1", "data": "hello"})
+
+        await store.create_table(
+            "late_table",
+            {"id": ColumnDefinition(type=ColumnType.STRING, primary_key=True), "value": ColumnType.STRING},
+        )
+        await store.insert("late_table", {"id": "a", "value": "world"})
+
+        result = await store.fetch_all("late_table")
+        assert len(result.data) == 1
+        assert result.data[0]["value"] == "world"
+
+        await store.shutdown()