fix(test): update bing and tavily tests for persistent client refactor

Upstream refactored search providers to use a persistent self._client
instead of creating a new httpx.AsyncClient per request. Update test
fixtures to set _client directly with a MagicMock instead of patching
the httpx.AsyncClient class methods.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Sébastien Han <seb@redhat.com>

Author: leseb

tests/unit/providers/tool_runtime/test_bing_search.py

@@ -4,7 +4,7 @@
 # This source code is licensed under the terms described in the LICENSE file in
 # the root directory of this source tree.
 
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock
 
 import httpx
 import pytest
@@ -15,7 +15,9 @@
 
 @pytest.fixture
 def bing_search():
-    return BingSearchToolRuntimeImpl(BingSearchToolConfig(api_key="test-key", top_k=3))
+    impl = BingSearchToolRuntimeImpl(BingSearchToolConfig(api_key="test-key", top_k=3))
+    impl._client = MagicMock(spec=httpx.AsyncClient)
+    return impl
 
 
 @pytest.fixture
@@ -39,79 +41,79 @@ def mock_bing_response():
 
 
 async def test_invoke_with_allowed_domains(bing_search, mock_bing_response):
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response) as mock_get:
-        await bing_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "allowed_domains": ["example.com", "docs.example.com"],
-            },
-        )
-        call_kwargs = mock_get.call_args
-        query_param = call_kwargs.kwargs["params"]["q"]
-        assert "site:example.com" in query_param
-        assert "site:docs.example.com" in query_param
-        assert query_param == "test query (site:example.com OR site:docs.example.com)"
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    await bing_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "allowed_domains": ["example.com", "docs.example.com"],
+        },
+    )
+    call_kwargs = bing_search._client.get.call_args
+    query_param = call_kwargs.kwargs["params"]["q"]
+    assert "site:example.com" in query_param
+    assert "site:docs.example.com" in query_param
+    assert query_param == "test query (site:example.com OR site:docs.example.com)"
 
 
 async def test_invoke_with_user_location_country(bing_search, mock_bing_response):
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response) as mock_get:
-        await bing_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "user_location": {"country": "US", "city": "San Francisco"},
-            },
-        )
-        call_kwargs = mock_get.call_args
-        assert call_kwargs.kwargs["params"]["cc"] == "US"
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    await bing_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "user_location": {"country": "US", "city": "San Francisco"},
+        },
+    )
+    call_kwargs = bing_search._client.get.call_args
+    assert call_kwargs.kwargs["params"]["cc"] == "US"
 
 
 async def test_invoke_with_search_context_size(bing_search, mock_bing_response):
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response) as mock_get:
-        await bing_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "search_context_size": "high",
-            },
-        )
-        call_kwargs = mock_get.call_args
-        assert call_kwargs.kwargs["params"]["count"] == 10
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    await bing_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "search_context_size": "high",
+        },
+    )
+    call_kwargs = bing_search._client.get.call_args
+    assert call_kwargs.kwargs["params"]["count"] == 10
 
 
 async def test_invoke_without_extra_params(bing_search, mock_bing_response):
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response) as mock_get:
-        await bing_search.invoke_tool(
-            "web_search",
-            {"query": "test query"},
-        )
-        call_kwargs = mock_get.call_args
-        params = call_kwargs.kwargs["params"]
-        assert params["q"] == "test query"
-        assert params["count"] == 3
-        assert "cc" not in params
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    await bing_search.invoke_tool(
+        "web_search",
+        {"query": "test query"},
+    )
+    call_kwargs = bing_search._client.get.call_args
+    params = call_kwargs.kwargs["params"]
+    assert params["q"] == "test query"
+    assert params["count"] == 3
+    assert "cc" not in params
 
 
 async def test_invoke_with_empty_allowed_domains(bing_search, mock_bing_response):
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response) as mock_get:
-        await bing_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "allowed_domains": [],
-            },
-        )
-        call_kwargs = mock_get.call_args
-        assert call_kwargs.kwargs["params"]["q"] == "test query"
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    await bing_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "allowed_domains": [],
+        },
+    )
+    call_kwargs = bing_search._client.get.call_args
+    assert call_kwargs.kwargs["params"]["q"] == "test query"
 
 
 async def test_invoke_returns_source_metadata(bing_search, mock_bing_response):
     """Test that invoke_tool returns source URLs in metadata."""
-    with patch("httpx.AsyncClient.get", new_callable=AsyncMock, return_value=mock_bing_response):
-        result = await bing_search.invoke_tool(tool_name="web_search", kwargs={"query": "test query"})
-        assert result.metadata is not None
-        assert "sources" in result.metadata
-        assert len(result.metadata["sources"]) == 1
-        assert result.metadata["sources"][0]["url"] == "https://example.com"
-        assert result.metadata["query"] == "test query"
+    bing_search._client.get = AsyncMock(return_value=mock_bing_response)
+    result = await bing_search.invoke_tool(tool_name="web_search", kwargs={"query": "test query"})
+    assert result.metadata is not None
+    assert "sources" in result.metadata
+    assert len(result.metadata["sources"]) == 1
+    assert result.metadata["sources"][0]["url"] == "https://example.com"
+    assert result.metadata["query"] == "test query"

tests/unit/providers/tool_runtime/test_tavily_search.py

@@ -4,7 +4,7 @@
 # This source code is licensed under the terms described in the LICENSE file in
 # the root directory of this source tree.
 
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock
 
 import httpx
 import pytest
@@ -15,7 +15,9 @@
 
 @pytest.fixture
 def tavily_search():
-    return TavilySearchToolRuntimeImpl(TavilySearchToolConfig(api_key="test-key", max_results=3))
+    impl = TavilySearchToolRuntimeImpl(TavilySearchToolConfig(api_key="test-key", max_results=3))
+    impl._client = MagicMock(spec=httpx.AsyncClient)
+    return impl
 
 
 @pytest.fixture
@@ -38,83 +40,83 @@ def mock_tavily_response():
 
 
 async def test_invoke_with_allowed_domains(tavily_search, mock_tavily_response):
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response) as mock_post:
-        await tavily_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "allowed_domains": ["example.com", "docs.example.com"],
-            },
-        )
-        call_kwargs = mock_post.call_args
-        request_body = call_kwargs.kwargs["json"]
-        assert request_body["include_domains"] == ["example.com", "docs.example.com"]
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    await tavily_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "allowed_domains": ["example.com", "docs.example.com"],
+        },
+    )
+    call_kwargs = tavily_search._client.post.call_args
+    request_body = call_kwargs.kwargs["json"]
+    assert request_body["include_domains"] == ["example.com", "docs.example.com"]
 
 
 async def test_invoke_with_search_context_size(tavily_search, mock_tavily_response):
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response) as mock_post:
-        await tavily_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "search_context_size": "high",
-            },
-        )
-        call_kwargs = mock_post.call_args
-        request_body = call_kwargs.kwargs["json"]
-        assert request_body["max_results"] == 10
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    await tavily_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "search_context_size": "high",
+        },
+    )
+    call_kwargs = tavily_search._client.post.call_args
+    request_body = call_kwargs.kwargs["json"]
+    assert request_body["max_results"] == 10
 
 
 async def test_invoke_without_extra_params(tavily_search, mock_tavily_response):
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response) as mock_post:
-        await tavily_search.invoke_tool(
-            "web_search",
-            {"query": "test query"},
-        )
-        call_kwargs = mock_post.call_args
-        request_body = call_kwargs.kwargs["json"]
-        assert request_body["query"] == "test query"
-        assert request_body["api_key"] == "test-key"
-        assert "include_domains" not in request_body
-        assert "max_results" not in request_body
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    await tavily_search.invoke_tool(
+        "web_search",
+        {"query": "test query"},
+    )
+    call_kwargs = tavily_search._client.post.call_args
+    request_body = call_kwargs.kwargs["json"]
+    assert request_body["query"] == "test query"
+    assert request_body["api_key"] == "test-key"
+    assert "include_domains" not in request_body
+    assert "max_results" not in request_body
 
 
 async def test_invoke_with_user_location_ignored(tavily_search, mock_tavily_response):
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response) as mock_post:
-        await tavily_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "user_location": {"country": "US", "city": "San Francisco"},
-            },
-        )
-        call_kwargs = mock_post.call_args
-        request_body = call_kwargs.kwargs["json"]
-        assert "user_location" not in request_body
-        assert "country" not in request_body
-        assert "location" not in request_body
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    await tavily_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "user_location": {"country": "US", "city": "San Francisco"},
+        },
+    )
+    call_kwargs = tavily_search._client.post.call_args
+    request_body = call_kwargs.kwargs["json"]
+    assert "user_location" not in request_body
+    assert "country" not in request_body
+    assert "location" not in request_body
 
 
 async def test_invoke_with_empty_allowed_domains(tavily_search, mock_tavily_response):
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response) as mock_post:
-        await tavily_search.invoke_tool(
-            "web_search",
-            {
-                "query": "test query",
-                "allowed_domains": [],
-            },
-        )
-        call_kwargs = mock_post.call_args
-        request_body = call_kwargs.kwargs["json"]
-        assert "include_domains" not in request_body
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    await tavily_search.invoke_tool(
+        "web_search",
+        {
+            "query": "test query",
+            "allowed_domains": [],
+        },
+    )
+    call_kwargs = tavily_search._client.post.call_args
+    request_body = call_kwargs.kwargs["json"]
+    assert "include_domains" not in request_body
 
 
 async def test_invoke_returns_source_metadata(tavily_search, mock_tavily_response):
     """Test that invoke_tool returns source URLs in metadata."""
-    with patch("httpx.AsyncClient.post", new_callable=AsyncMock, return_value=mock_tavily_response):
-        result = await tavily_search.invoke_tool(tool_name="web_search", kwargs={"query": "test query"})
-        assert result.metadata is not None
-        assert "sources" in result.metadata
-        assert len(result.metadata["sources"]) == 1
-        assert result.metadata["sources"][0]["url"] == "https://example.com"
-        assert result.metadata["query"] == "test query"
+    tavily_search._client.post = AsyncMock(return_value=mock_tavily_response)
+    result = await tavily_search.invoke_tool(tool_name="web_search", kwargs={"query": "test query"})
+    assert result.metadata is not None
+    assert "sources" in result.metadata
+    assert len(result.metadata["sources"]) == 1
+    assert result.metadata["sources"][0]["url"] == "https://example.com"
+    assert result.metadata["query"] == "test query"