Skip to content

Commit 48dade9

Browse files
r3v5claude
andcommitted
style(vector_io): fix ruff format line length in pool test
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ian Miller <milleryan2003@gmail.com>
1 parent 86c6a9b commit 48dade9

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

src/ogx/providers/remote/vector_io/pgvector/pgvector.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ async def create_hnsw_vector_index(self, conn: asyncpg.Connection) -> None:
582582
index_operator_class = self.get_pgvector_index_operator_class()
583583
index_name = _quote_ident(f"{self.table_name}_hnsw_idx")
584584

585+
# Create HNSW (Hierarchical Navigable Small Worlds) index on embedding column to allow efficient and performant vector search in pgvector
586+
# HNSW finds the approximate nearest neighbors by only calculating distance metric for vectors it visits during graph traversal instead of processing all vectors
585587
await conn.execute(
586588
f"""
587589
CREATE INDEX IF NOT EXISTS {index_name}
@@ -623,6 +625,9 @@ async def create_ivfflat_vector_index(self, conn: asyncpg.Connection) -> None:
623625
index_operator_class = self.get_pgvector_index_operator_class()
624626
index_name = _quote_ident(f"{self.table_name}_ivfflat_idx")
625627

628+
# Create Inverted File with Flat Compression (IVFFlat) index on embedding column to allow efficient and performant vector search in pgvector
629+
# IVFFlat index divides vectors into lists, and then searches a subset of those lists that are closest to the query vector
630+
# Index should be created only after the table has some data (https://github.com/pgvector/pgvector?tab=readme-ov-file#ivfflat)
626631
await conn.execute(
627632
f"""
628633
CREATE INDEX IF NOT EXISTS {index_name}

tests/unit/providers/vector_io/test_vector_io_stores_config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,9 @@ async def test_adapter_initialize_cleans_up_pool_on_index_failure():
475475
adapter = _make_pgvector_adapter()
476476
pool, mock_conn = _make_mock_asyncpg_pool()
477477

478-
with patch("ogx.providers.remote.vector_io.pgvector.pgvector.kvstore_impl", new_callable=AsyncMock) as mock_kvstore_impl:
478+
with patch(
479+
"ogx.providers.remote.vector_io.pgvector.pgvector.kvstore_impl", new_callable=AsyncMock
480+
) as mock_kvstore_impl:
479481
mock_kvstore = AsyncMock()
480482
mock_kvstore.values_in_range = AsyncMock(
481483
return_value=['{"identifier":"vs1","embedding_model":"m","embedding_dimension":768,"provider_id":"p"}']

0 commit comments

Comments
 (0)